-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding AIX support for Issue #137 #139
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Thomas Cate <tcate@chef.io>
Signed-off-by: Thomas Cate <tcate@chef.io>
This code was tested using chef-client 12. Currently the AIX cookbook it depends on does not support chef-client 13. |
for accuracy's sake, the code was tested using AIX 7.1 and Chef 12.22.1, along with the following cookbook versions from Supermarket:
|
@@ -23,17 +23,17 @@ | |||
# See libraries/helpers for the PushJobsHelper module. | |||
directory PushJobsHelper.config_dir do | |||
unless platform_family?('windows') | |||
owner 'root' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should just remove the owner/group since root / root is the default and we'll pick the right one based on platform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this default to "0" on AIX and not "root"? I no longer have an AIX test platform to confirm that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be doing the right thing on AIX just like we do the right thing on other *nix releases.
Description
Adding AIX support to the Push Jobs Cookbook.
Issues Resolved
#137
Check List