Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding AIX support for Issue #137 #139

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

thomascate
Copy link

Description

Adding AIX support to the Push Jobs Cookbook.

Issues Resolved

#137

Check List

@thomascate
Copy link
Author

This code was tested using chef-client 12. Currently the AIX cookbook it depends on does not support chef-client 13.

@moutons
Copy link

moutons commented Mar 21, 2018

for accuracy's sake, the code was tested using AIX 7.1 and Chef 12.22.1, along with the following cookbook versions from Supermarket:

  • aix (2.2.0)
  • chef-ingredient (2.3.0)
  • runit (4.0.4)
  • yum-epel (3.1.0)

@@ -23,17 +23,17 @@
# See libraries/helpers for the PushJobsHelper module.
directory PushJobsHelper.config_dir do
unless platform_family?('windows')
owner 'root'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just remove the owner/group since root / root is the default and we'll pick the right one based on platform

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this default to "0" on AIX and not "root"? I no longer have an AIX test platform to confirm that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be doing the right thing on AIX just like we do the right thing on other *nix releases.

@tas50 tas50 added Triage: Needs Information Indicates an issue needs more information in order to work on it. and removed Status: Pending Contributor Response labels Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triage: Needs Information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants