feat: support wildcard exports when parsing dependency tree [sc-22632] #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new flag, `--debug-bundle`, outputs the project bundle payload as-is after the project has been parsed. The bundle is output to a file, by default `./debug-bundle.json`. A different file can be chosen with the new `--debug-bundle-output-file` flag, which is also hidden.
Previously only named exports were supported.
Additionally, to make sure that not all files in the tree are getting included automatically (which would have invalidated the wildcard export tests), an unreachable file that should not appear in the list of dependencies was added to the relevant examples.
sorccu
force-pushed
the
simokinnunen/sc-22632/handle-wildcard-exports-in-the-cli-parser
branch
from
7939686 to
96c41c0
Compare
sorccu
changed the title
sorccu
deleted the
simokinnunen/sc-22632/handle-wildcard-exports-in-the-cli-parser
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the project parser compatible with wildcard exports such as
export * from './file'. Previously, only named exports such asexport { Thing } from './file'were supported. The end result was that the file being referred to in the export would not be added to the dependency tree.I hereby confirm that I followed the code guidelines found at engineering guidelines
Affected Components
Notes for the Reviewer
New Dependency Submission