Implement GainData as dataclass #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes on the one hand a syntax error in the string formatting performed within the `__str__` method by removing it and relying on the method provided by the dataclass. On the other hand, this change allowed to remove also the `__repr__`, `__eq__` and `__ne__` methods, which are also provided by the dataclass wrapper.
chaudum
commented
Mar 31, 2021
| self.gain_type = gain_type | ||
|
|
||
| def __str__(self): | ||
| return "gain={.2f} dB; peak={.8f}; reference-level={} dB".format( |
There was a problem hiding this comment.
The syntax error was caused by the float fomatting, which misses the colon and should be {:2f}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes on the one hand a syntax error in the string formatting
performed within the
__str__method by removing it and relying on themethod provided by the dataclass.
On the other hand, this change allowed to remove also the
__repr__,__eq__and__ne__methods, which are also provided by the dataclasswrapper.