Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to chartjs v4 and fix bugs #170

Merged
merged 12 commits into from
Mar 23, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 32 additions & 6 deletions .eslintrc.yml
Original file line number Diff line number Diff line change
@@ -1,35 +1,61 @@
extends:
- chartjs
- plugin:es/no-new-in-es2019
- plugin:es/restrict-to-es2018
- plugin:markdown/recommended

settings:
es:
aggressive: true

env:
es6: true
browser: true
jasmine: true
node: true

parserOptions:
ecmaVersion: 2018
ecmaVersion: 2022
sourceType: module
ecmaFeatures:
impliedStrict: true
modules: true
experimentalObjectRestSpread: true

plugins: ['html', 'es']


rules:
class-methods-use-this: "off"
complexity: ["warn", 10]
indent: ["error", "tab"]
max-statements: ["warn", 30]
no-empty-function: "off"
no-use-before-define: ["error", { "functions": false }]
# disable everything, except Rest/Spread Properties in ES2018
es/no-import-meta: "off"
es/no-async-iteration: "error"
es/no-malformed-template-literals: "error"
es/no-regexp-lookbehind-assertions: "error"
es/no-regexp-named-capture-groups: "error"
es/no-regexp-s-flag: "error"
es/no-regexp-unicode-property-escapes: "error"
es/no-dynamic-import: "off"

overrides:
- files: ['**/*.ts']
parser: '@typescript-eslint/parser'
plugins:
- '@typescript-eslint'
extends:
- chartjs
- plugin:@typescript-eslint/recommended

rules:
complexity: ["warn", 10]
max-statements: ["warn", 30]
# Replace stock eslint rules with typescript-eslint equivalents for proper
# TypeScript support.
indent: "off"
"@typescript-eslint/indent": ["error", 2]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a mix of formatting in this file. this rule is surrounded by double quotes and it's single quotes two lines below

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-use-before-define: "off"
'@typescript-eslint/no-use-before-define': "error"
no-shadow: "off"
'@typescript-eslint/no-shadow': "error"
space-before-function-paren: "off"
'@typescript-eslint/space-before-function-paren': [2, never]
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '14'
node-version: 'lts/*'
cache: npm
- uses: dorny/paths-filter@v3
id: changes
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '14.x'
node-version: 'lts/*'
registry-url: https://registry.npmjs.org/
cache: npm
- name: Setup and build
Expand Down
19 changes: 0 additions & 19 deletions .travis.yml

This file was deleted.

Loading
Loading