-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to chartjs v4 and fix bugs #170
Merged
Merged
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0e49e6a
Upgrade to chartjs v4 and fix bugs
santam85 5daf5fa
Use node LTS
santam85 5c0ece6
Fix tests
santam85 483ef00
Fix coverage
santam85 1e9c0dc
Add Firefox tests
santam85 593fcae
Reduce complexity
santam85 4ba4881
Replace var
santam85 37ffa27
Fixed html indentation as per PR comments
santam85 623316c
Update docs/index.html
santam85 1fa3e97
Fixed doc comments indentation
santam85 83abb12
Fixed html indentation as per PR comments
santam85 28d7892
Added info on README
santam85 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,35 +1,61 @@ | ||
extends: | ||
- chartjs | ||
- plugin:es/no-new-in-es2019 | ||
- plugin:es/restrict-to-es2018 | ||
- plugin:markdown/recommended | ||
|
||
settings: | ||
es: | ||
aggressive: true | ||
|
||
env: | ||
es6: true | ||
browser: true | ||
jasmine: true | ||
node: true | ||
|
||
parserOptions: | ||
ecmaVersion: 2018 | ||
ecmaVersion: 2022 | ||
sourceType: module | ||
ecmaFeatures: | ||
impliedStrict: true | ||
modules: true | ||
experimentalObjectRestSpread: true | ||
|
||
plugins: ['html', 'es'] | ||
|
||
|
||
rules: | ||
class-methods-use-this: "off" | ||
complexity: ["warn", 10] | ||
indent: ["error", "tab"] | ||
max-statements: ["warn", 30] | ||
no-empty-function: "off" | ||
no-use-before-define: ["error", { "functions": false }] | ||
# disable everything, except Rest/Spread Properties in ES2018 | ||
es/no-import-meta: "off" | ||
es/no-async-iteration: "error" | ||
es/no-malformed-template-literals: "error" | ||
es/no-regexp-lookbehind-assertions: "error" | ||
es/no-regexp-named-capture-groups: "error" | ||
es/no-regexp-s-flag: "error" | ||
es/no-regexp-unicode-property-escapes: "error" | ||
es/no-dynamic-import: "off" | ||
|
||
overrides: | ||
- files: ['**/*.ts'] | ||
parser: '@typescript-eslint/parser' | ||
plugins: | ||
- '@typescript-eslint' | ||
extends: | ||
- chartjs | ||
- plugin:@typescript-eslint/recommended | ||
|
||
rules: | ||
complexity: ["warn", 10] | ||
max-statements: ["warn", 30] | ||
# Replace stock eslint rules with typescript-eslint equivalents for proper | ||
# TypeScript support. | ||
indent: "off" | ||
"@typescript-eslint/indent": ["error", 2] | ||
no-use-before-define: "off" | ||
'@typescript-eslint/no-use-before-define': "error" | ||
no-shadow: "off" | ||
'@typescript-eslint/no-shadow': "error" | ||
space-before-function-paren: "off" | ||
'@typescript-eslint/space-before-function-paren': [2, never] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a mix of formatting in this file. this rule is surrounded by double quotes and it's single quotes two lines below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copied from parent project: https://github.com/chartjs/Chart.js/blob/master/.eslintrc.yml 🤷