-
Notifications
You must be signed in to change notification settings - Fork 8
docs: add VM instance compatibility matrix #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
4d19681
to
c147f19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Definitely some useful information to have available to users - we'll want to update as we test on other VMs. I've made just a few suggestions on phrasing and maybe a different title.
reference/compatibility-matrix.md
Outdated
@@ -0,0 +1,76 @@ | |||
(reference-compatibility-matrix)= | |||
# Compatibility Matrix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like 'VM compatibility' might be better as a title, since the current title doesn't hint at what is/is not compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I've changed the title to "Virtual machine compatibility" for clarity.
190fdee
to
8de4e9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion about adding a note.
Once the release policy is confirmed, we'll likely want to either add a column noting which Charmed HPC release is being tested, or have a unique page/section for each release. Since the release policy should be implemented in near future, we should potentially leave this PR unmerged until those updates can be made. Thoughts?
Co-authored-by: Ashley Cliff <ashley.cliff@canonical.com>
Co-authored-by: Ashley Cliff <ashley.cliff@canonical.com>
Co-authored-by: Ashley Cliff <ashley.cliff@canonical.com>
8191fa0
to
3f96798
Compare
Note has been added and I've rebased on current Yes, I think that's a good idea to keep this un-merged for now. We can update when we have the release policy in place. |
Adds a compatibility matrix reference page for VM instance types that have been used for testing Charmed HPC on Azure.
At the moment, this is mostly beneficial for the
slurmd
charm, as this has been tested on a few different combinations of instances to confirm RDMA and GPU compatibility. The remaining charms have been exclusively run onStandard_D2as_v6
instances, Juju's default for Azure.