Use ansi color terminal palette by default

[chtenb]

Describe the bug
The colors used by this app are not so readable on some terminal themes

If you would stick to the 8 basic ansi colors for the foreground, this issue should be resolved for everyone, and also adapt to their terminal color palette automatically.

[meowgorithm]

Hi! Funny, we just opened a PR for a 4-bit ANSI color scheme: #22

But also, Sequin has a light background theme that should be automatically enabled when needed, so I'm curious why the detection isn't working.

What terminal, shell and operating system are you using?

[chtenb]

Wezterm, nushell, windows

[mkotowski]

Edit 3: Correction, I ran WezTerm tests inside terminal multiplexer, it seems termenv on which lipgloss depends ignores tmux and screen based on $TERM for OSC queries like OSC 11 ; ? ST (https://github.com/muesli/termenv/blob/master/termenv_unix.go#L235). Outside it, detection seems to work as intended.

Faulty tests from inside multiplexer

Hi, I can confirm that it seems to affect WezTerm + bash + Linux too. Confirmed by switching themes on single session in Konsole on the same system and it works OK. Verified Konsole's and WezTerm's support for background detection by simply running `echo -en '\x1b]11;?\a'`. Issue seems to affect even more closely white themes (tested '3024 Day (Gogh)' on WezTerm).

Edit 2:
Stranger still, it seems to work OK in WezTerm if run inside a docker image (same config as in screenshots above):

Edit:
Tested versions:

• WezTerm: flatpak 20240203-110809-5046fc22
• Konsole: 23.08.5

[chtenb]

I'm not sure how the light/dark theme would be detected by applications? There is no env variable set, from what I can see. My terminal apps all use ANSI colors, and these are mapped by my wezterm config to certain colors, based on the system theme.

[aymanbagabas]

Edit 3: Correction, I ran WezTerm tests inside terminal multiplexer, it seems termenv on which lipgloss depends ignores tmux and screen based on $TERM for OSC queries like OSC 11 ; ? ST (https://github.com/muesli/termenv/blob/master/termenv_unix.go#L235). Outside it, detection seems to work as intended.

@mkotowski Keep in mind that Sequin uses Lip Gloss v2 which doesn't depend on Termenv. See terminal.go for more details.

[caarlos0]

@mkotowski also, you might want to add something like this to your tmux config:

https://github.com/caarlos0/dotfiles/blob/ce5c7d240c0fd440b61453f1466b7015376eeaba/modules/tmux/tmux.conf#L1-L2

make sure to set it to your actual terminal though, mine is ghostty so that's what I have there.

[meowgorithm]

@chtenb We can auto-detect the background color either via OSC or environment variable depending on the terminal and system (@aymanbagas, correct me if I'm wrong here).

What it sounds like is that Windows isn't detecting the background color because input is a pipe. We're looking into this.

In the meantime we'll merge #22.

[ayman]

@meowgorithm you tagged the wrong ayman...you want @aymanbagabas.

[aymanbagabas]

I've opened charmbracelet/lipgloss#444 to fix this issue in Lip Gloss v2.

[meowgorithm]

@ayman Sorry about that, though it's nice to meet the person behind the original Ayman handle. It looks like you're working on some cool stuff.

[mkotowski]

@aymanbagabas Thanks! I missed that. 🙂

@caarlos0 Thanks for the tip, but I have both COLORTERM set to the truecolor and TERM set to xterm-256color and the issue is till present in my case:

And after exiting tmux in the same session:

[aymanbagabas]

@mkotowski What's your Tmux version?

[mkotowski]

@aymanbagabas tmux 3.2a, beyond setting COLORTERM and TERM no customization in my conf file, running inside ubuntu 22.04 image set-up using distrobox.

[aymanbagabas]

@aymanbagabas tmux 3.2a, beyond setting COLORTERM and TERM no customization in my conf file, running inside ubuntu 22.04 image set-up using distrobox.

Sounds about right. Tmux added support to OSC10/11 query in 3.4 see https://github.com/tmux/tmux/blob/master/CHANGES#L152

[mkotowski]

Ah, I see 🤦, why did I thought it was introduced in an earlier version? Then sorry for a false alarm 😅

[aymanbagabas]

Ah, I see 🤦, why did I thought it was introduced in an earlier version? Then sorry for a false alarm 😅

No worries, we should put a note somewhere about Tmux and GNU Screen.