Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build site with CSP disabled #29

Merged
merged 1 commit into from
Jun 14, 2024
Merged

fix: build site with CSP disabled #29

merged 1 commit into from
Jun 14, 2024

Conversation

welpo
Copy link
Contributor

@welpo welpo commented Jun 5, 2024

Description

The site failed to build with csp disabled. The reason was the CSP block was setting the page_image variable, but the last styling section of head.html had an if checking for page.extra.image but using page_image if set.

Notes:

  • Might want to set page_image outside the csp block;
  • In any case, I believe the if should check for the variable that will later be used (whether it's page.extra.image or page_image).

Motivation

Site should build regardless of csp setting.

Logs (if applicable)

Checklist:

<!— Go over all the following points and put an x in all the boxes that apply. —>

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.

Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for halve-z ready!

Name Link
🔨 Latest commit 18ec332
🔍 Latest deploy log https://app.netlify.com/sites/halve-z/deploys/6660cb5cc0b407000702084b
😎 Deploy Preview https://deploy-preview-29--halve-z.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@charlesrocket charlesrocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I missed this one, thanks!

@charlesrocket charlesrocket merged commit 451bafd into charlesrocket:trunk Jun 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants