Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding improved informer date range coverage #11

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

magaldima
Copy link
Contributor

@magaldima magaldima commented Feb 5, 2025

This PR does a few important things:

  • Adds nullable external_created_at timestamp to the delta_resource table along with an optional interface for Objects to implement to expose a CreatedAt() method.
  • Renames Since InformOpt to After and beef up the description of this field.
  • Updated informer logic around the last_inform_time of a delta_controller to respect the last informed resource's external_created_at (this ensures 0 gaps in possible races that existed using time.Now() )

Copy link

@themaxgoldman themaxgoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good I appreciate the extra documentation. External created at is definitely important here.

@magaldima magaldima merged commit 4f9467b into main Feb 5, 2025
7 checks passed
@magaldima magaldima deleted the enhancements-2 branch February 5, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants