Fix FirmwareStatusNotificationRequest(status = Installed) (refs EVEREST-1175) #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabian Hartung <fabian.hartung@chargebyte.com>
barsnick
approved these changes
Sep 4, 2024
…ST-1175) The variable to publish FirmwareStatusNotification::Installed message is now delayed, because the message is dropped in case the OCPP client is not connected or the OCPP module is not yet subscribed to the variable. This is only a temporary solution as long as the reported issues (EVerest/libocpp#758, EVerest/everest-core#841) are not fixed. Signed-off-by: Fabian Hartung <fabian.hartung@chargebyte.com>
FaHaGit
force-pushed
the
Fix_FirmwareStatusNotificationReq_Installed_v2
branch
from
409604f to
da46425
Compare
Signed-off-by: Fabian Hartung <fabian.hartung@chargebyte.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable to publish FirmwareStatusNotification::Installed message is
now delayed, because the message is dropped in case the OCPP client is
not connected or the OCPP module is not yet subscribed to the variable.
This is only a temporary solution to pass TC_L_01 OCPP 2.0.1 test case
and should be removed as soon as a proper fixes are implemented in
the reported issues (EVerest/libocpp#758,
EVerest/everest-core#841).