Skip to content

Commit

Permalink
Migrate flat, flat-square, plastic and social to use XmlElement (ba…
Browse files Browse the repository at this point in the history
…dges#6883)

* start changelog entry for v4

* migrate Flat/FlatSquare/Plastic to use XmlElement

* move brightnessThreshold into colorsForBackground

* move old renderLogo function inline into social()

this is the only place it is now used

* use XmlElement in social()

* don't quote numbers if we don't need to

* remove intermediate calls to .render()

leave everything as XmlElement objects right till the end
then make one final call to .render()
which cascades aaall the way through the tree

* factor out code for assembling logo element

* use scale consts in social

* remove NullElement

now we've removed all the intermediate calls to render()
we can just use an empty string

* write leftlink so it doesn't look like a bool

Co-authored-by: Caleb Cartwright <calebcartwright@users.noreply.github.com>
  • Loading branch information
chris48s and calebcartwright authored Aug 21, 2021
1 parent 1c36dd2 commit e8c78d5
Show file tree
Hide file tree
Showing 3 changed files with 521 additions and 313 deletions.
4 changes: 4 additions & 0 deletions badge-maker/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 4.0.0 [WIP]

- Drop compatibility with Node 10

## 3.3.1

- Improve font measuring in for-the-badge and social styles
Expand Down
Loading

0 comments on commit e8c78d5

Please sign in to comment.