Only Save Config Differences Back to DB #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On each page load the sccpsettings table would get truncated and repopulated with the same data causing a big bottleneck. Now we will only attempt to save settings to the DB that have changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SCCP Phone Manager page was taking over 12 seconds (on very old hardware) to load for me (with ~15 phones configured). After some profiling, I saw sccp_manager was truncating the sccpsettings table on every pageload, then inserting the exact same settings back into the database. This was severely hurting my ability to configure phones in a timely manner.
It seems there are many ways to optimize sccp_manager to reduce page load time. I focused on only saving the difference of sccpvalues in order to achieve around 6x speedup. Now when loading SCCP Phone Manager page, sccpsettings will not be truncated. Instead settings will be updated by row as needed.
Please let me know if you would like me ot refactor, rename, comment, or test this some more. I was able to change phone and line settings, as well as server config settings with the new code.