refactor runner implementations #1414
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Hall <jason@chainguard.dev>
89luca89
reviewed
Aug 5, 2024
| } | ||
| } | ||
|
|
||
| switch runtime.GOOS { |
There was a problem hiding this comment.
I think with the new implementation we're missing this, so e2e are failing because we don't have a default now, but it expect explicitly to be set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors and centralizes how runner implementations are registered and selected. Existing runners (docker, bubblewrap, experimentaldagger) are unaffected, and can still be selected automatically or with the
--runnerflag.This enables other callers of melange's Go library to register their own implementations without having to modify melange's source code. Registering can be done in
func initor infunc main, any time beforeGetRunneris called.