Fix: Nondestructive replaceWith for imageReady (fixes #13)

cgkineo · Sep 5, 2023 · df56e15 · df56e15
1 parent a7540e2
commit df56e15
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/js/adapt-graphicLottie.js b/js/adapt-graphicLottie.js
@@ -42,7 +42,15 @@ class GraphicLottie extends Backbone.Controller {
     const $img = $(img);
     const div = document.createElement('div');
     const $div = $(div);
-    $img.replaceWith($div);
+
+    // Do replaceWith using detach instead of remove to preserve
+    // imageready event listeners
+    const $parent = $img.parent();
+    const previousSibling = $img[0].previousSibling;
+    $img.detach();
+    if (!previousSibling) $parent.prepend($div);
+    else $div.insertAfter(previousSibling);
+
     const lottieView = div.lottieView = new LottieView({
       el: div,
       replacedEl: img