Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize URL for services #242

Open
capooti opened this issue Feb 8, 2017 · 6 comments
Open

Sanitize URL for services #242

capooti opened this issue Feb 8, 2017 · 6 comments
Assignees
@tomkralidis
Labels
MapProxy
Milestone
0.4

Comments

@capooti
Copy link
Contributor

capooti commented Feb 8, 2017

There are many cases where url for endpoints should be sanitized.

For example this url for a WMS:
http://tepeserwery.pl/tileservice/wms.php/icrsptixwh?SERVICE=WMS&VERSION=1.1.1&REQUEST=GetCapabilities

should be sanitized to:
http://tepeserwery.pl/tileservice/wms.php/icrsptixwh?

Otherwise MapProxy will not work properly as there will be both a GetCapabilities and a GetMap in the request.

There are complex case to keep in account such as: http://host/mywms?map=foo.map
@capooti capooti self-assigned this Feb 8, 2017
@capooti capooti added this to the 0.4 milestone May 23, 2017
@capooti capooti assigned dkakkar and zhangmingda and unassigned capooti May 23, 2017
@capooti capooti assigned tomkralidis and unassigned dkakkar and zhangmingda Jun 28, 2017
@capooti capooti removed the easy-pick label Jun 28, 2017
@tomkralidis tomkralidis mentioned this issue Jun 28, 2017
Closed
@tomkralidis
Copy link
Contributor

As discussed this will be fixed in OWSLib.

@tomkralidis
Copy link
Contributor

FYI this is been implemented in OWSLib (master branch), so that OWSLib classes will take care of cleaning the URL when invoked/initiated.

@capooti
Copy link
Contributor Author

capooti commented Jun 30, 2017

great! When are you planning a release?

@tomkralidis
Copy link
Contributor

Next couple of weeks. Feel free to remind if things drag on past that.

@capooti
Copy link
Contributor Author

capooti commented Jun 30, 2017

Excellent. @lordofhogwarts when @tomkralidis make the release could you bump it to requirements.txt?

@blewis
Copy link
Contributor

blewis commented Jun 30, 2017

Thanks Tom!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomkralidis tomkralidis

Labels
MapProxy
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
5 participants
@capooti @blewis @tomkralidis @dkakkar @zhangmingda