[e2e] [Complete user profile - unassociated] Ensure first name / last name have char limits #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanner-ricks
requested review from
billhimmelsbach,
meissadia,
shindigira and
ojbravo
as code owners
There was a problem hiding this comment.
Looking good!
Could we make a ticket for future work, and then link it here in the code so we don't lose track of it?
I could see in that ticket:
- adding max lengths to inputs in coordination with the backend team (after the DevChat on Monday)
- a util function that checks a given input field to see if it passes the check
- using that util function to check our existing inputs
Future work:
- right now first name and last name restrict just based on maxLength, but we could make future tests to check that trying to submit data with restricted char sets (after some discussion) throws an error as well
e2e/pages/shared-lending-platform/NonAssociatedUserProfile.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Looks great @tanner-ricks! Thanks for adding the TODO comment. Looking forward to chatting about this in DevChat!
A great first PR of many!
|
|
…-profile-ensure-char-limits
|
|
billhimmelsbach
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Giving you the approval, but I'm hoping some more congrats gifs are coming @tanner-ricks! 🎉
Welcome to the team!
|
|
|
Nice work!!! |
tanner-ricks
deleted the
970-e2e-complete-user-profile-ensure-char-limits
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Characters limits and unicode character input tolerance need to be validated in an e2e test.
Changes
How to test this PR