Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updates navigation.spec.ts #966

Merged
merged 4 commits into from
Sep 27, 2024
Merged

fix: Updates navigation.spec.ts #966

merged 4 commits into from
Sep 27, 2024

Conversation

shindigira
Copy link
Contributor

closes #965

Changes

  • Fix: Update to Navigation.spec.ts

How to test

  • Run yarn run test:e2e
  • Runnthe Navigation.spec.ts test

@shindigira shindigira mentioned this pull request Sep 25, 2024
Merged
billhimmelsbach
billhimmelsbach reviewed Sep 27, 2024
View reviewed changes
Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heyo, messaged ya about this one. Let's quickly chat about it.

billhimmelsbach
billhimmelsbach approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we figured it out! Tests are passing so this one is good to go!
Screenshot 2024-09-27 at 4 20 44 PM

@shindigira shindigira merged commit 260fcb6 into main Sep 27, 2024
4 checks passed
@shindigira shindigira deleted the navigation-test-fix branch September 27, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billhimmelsbach billhimmelsbach billhimmelsbach approved these changes

@meissadia meissadia Awaiting requested review from meissadia meissadia is a code owner

@ojbravo ojbravo Awaiting requested review from ojbravo ojbravo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[e2e] Fix Navigation.spec.ts
2 participants
@shindigira @billhimmelsbach