-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[e2e] [Upload] Tests for syntax errors, logic errors and to verify a downloadable report #938
Conversation
…ntend into 777-all-syntax-errors-again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we can modify/improve Omar's uploadFile.ts
for these upload tests? It would be great to have a centralized place for uploading logic if it makes sense to do so.
…frontend into 937-download-report-validation
Updated the |
…-report-validation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! A couple opportunities to reduce code duplication.
e2e/pages/filing-app/uploadFile/completeUploadLogicErrors.spec.ts
Outdated
Show resolved
Hide resolved
e2e/pages/filing-app/uploadFile/completeUploadLogicErrors.spec.ts
Outdated
Show resolved
Hide resolved
…-report-validation
…frontend into 937-download-report-validation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏾
closes #777
closes #802
closes #937
closes #958
Changes
playwright.config.ts
e2e/pages/filing-app/uploadFile/downloads
directory after the download report test finishesuploadFile.ts
to be DRYuploadFile.ts
with completeUploadLogicErrors.spec.tsuploadFile.ts
with completeUploadSyntaxErrors.spec.tsunavailableApis.spec.ts
withuploadFile.ts
accordinglyHow to Test
npx playwright test --ui
completeSyntaxErrors.spec.ts
testcompleteLogicErrors.spec.ts
testunavailableApis.spec.ts
teste2e/pages/filing-app/uploadFile/downloads
Screenshot