Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e(UploadFile): Tests for syntax errors and logic errors #921

Closed
wants to merge 8 commits into from
Closed

e2e(UploadFile): Tests for syntax errors and logic errors #921

wants to merge 8 commits into from

Conversation

shindigira
Copy link
Contributor

@shindigira shindigira commented Sep 10, 2024 •
edited
Loading

closes #777
closes #802

Changes

  • Adds e2e test to check the navigation of when a user uploads a csv that produces syntax errors
  • Adds e2e test to check the navigation of when a user uploads a csv that produces logic errors

How to Test

  • Run npx playwright test --ui
  • Run the completeUploadSyntaxErrors.spec.ts test
  • Run the completeUploadLogicErrors.spec.ts test

Screenshot

Screenshot 2024-09-18 at 12 19 51 PM

@shindigira shindigira changed the title e2e(UploadFile): Testing e2e/pages/filing-app/UploadFile with all_syntax_errors.csv e2e(UploadFile): Tests syntax errors and logic errors Sep 18, 2024
@shindigira shindigira changed the title e2e(UploadFile): Tests syntax errors and logic errors e2e(UploadFile): Tests for syntax errors and logic errors Sep 18, 2024
@shindigira shindigira closed this Sep 19, 2024
@shindigira
Copy link
Contributor Author

combined this with #938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billhimmelsbach billhimmelsbach Awaiting requested review from billhimmelsbach billhimmelsbach is a code owner

@meissadia meissadia Awaiting requested review from meissadia meissadia is a code owner

@ojbravo ojbravo Awaiting requested review from ojbravo ojbravo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[e2e] Upload All Logic Errors - Resolve Errors (Logic) [e2e] Upload All Syntax Errors
1 participant
@shindigira