Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Setup] Tailwind Configuration, Eslint Changes, Prettier Changes #8

Merged
merged 8 commits into from
Aug 1, 2023
Merged

[Setup] Tailwind Configuration, Eslint Changes, Prettier Changes #8

merged 8 commits into from
Aug 1, 2023

Conversation

shindigira
Copy link
Contributor

@shindigira shindigira commented Jul 27, 2023 •
edited
Loading

Closes #6

Changes

  • Enabled Tailwind - Allow Tailwind classes to cause style changes
  • Disabled Tailwind Preflight (for now, can re-enable if it doesn't interfere with the imported CFPB Design Styles)
  • Added .prettierignore and .gitignore
  • Addressed the JSX.intrinsicElement has 'implicit' _any_ error.
  • Reduced eslint and typescript errors
  • Updated Yarn cache.
  • Prettified all code

How to Test

  • Open up Home.tsx and change lines 65-68 to:
    <a key='sidenav_2' href='/' className='bg-red-100'>
      Some other page
    </a>

You should see what's in the comment below.

@shindigira
chore: Dev Environment Updates
f1bfca3 
Changes:
- [Fix] Tailwind Enabled
- [Chore] prettier and eslint ignore files
- [Chore] absolute pathing
@shindigira
chore:yarn cache updates
c0f07e6
@shindigira
Dev Environment Updates
4aa1d18 
    Changes:
    - [Fix] Tailwind Enabled
    - [Chore] prettier and eslint ignore files
    - [Chore] absolute pathing
    - [Fix] typescript-eslint error -- JSX.IntrinsicElement
    - [Chore] Updated Yarn cache
    - [Chore] Used **Prettier** to prettify all code
@shindigira
revert: className
7f173e9
@shindigira
fix: typescript Error for Head.tsx
f26132e
@shindigira shindigira self-assigned this Jul 27, 2023
@shindigira shindigira added the enhancement New feature or request label Jul 27, 2023
@shindigira
Copy link
Contributor Author

Screen Shot 2023-07-27 at 2 41 15 AM

@shindigira shindigira changed the title Tailwind Configuration, Eslint Changes, Prettier Changes, Absolute Pathing Tailwind Configuration, Eslint Changes, Prettier Changes Jul 27, 2023
@shindigira shindigira changed the title Tailwind Configuration, Eslint Changes, Prettier Changes [Dev Environment] Tailwind Configuration, Eslint Changes, Prettier Changes Jul 27, 2023
@shindigira shindigira changed the title [Dev Environment] Tailwind Configuration, Eslint Changes, Prettier Changes [Setup] Tailwind Configuration, Eslint Changes, Prettier Changes Jul 27, 2023
shindigira
shindigira commented Jul 27, 2023
View reviewed changes
src/index.css
@@ -1 +1,5 @@
@import url('@trussworks/react-uswds/lib/index.css');

@tailwind base;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the main issue.

meissadia
meissadia reviewed Jul 27, 2023
View reviewed changes
prettier.config.cjs Outdated Show resolved Hide resolved
meissadia
meissadia approved these changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Love the conventional commit messages 👍🏾.

@shindigira @meissadia
Update prettier.config.cjs
3a30314 
Added the `tailingComma: 'all'` change.

Co-authored-by: Meis <meissadia@gmail.com>
contolini
contolini approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning everything up!

@shindigira
Copy link
Contributor Author

shindigira commented Jul 31, 2023 •
edited
Loading

@contolini Did you have additional questions before I merge this in? Just doublechecking!

@contolini
Copy link
Member

@shindigira Nah, merge away!

@shindigira shindigira merged commit dc4a402 into main Aug 1, 2023
1 check passed
@meissadia meissadia deleted the 6-tailwind-configuration branch August 1, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@contolini contolini contolini approved these changes

@meissadia meissadia meissadia approved these changes

@lchen-2101 lchen-2101 Awaiting requested review from lchen-2101

Assignees

@shindigira shindigira

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug][Dependency] Tailwind - Installed, configured, but not working?
3 participants
@shindigira @contolini @meissadia