Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Resolve Errors & Warnings] Download Validation Report #447

Merged
merged 129 commits into from
May 7, 2024
Merged

[Resolve Errors & Warnings] Download Validation Report #447

merged 129 commits into from
May 7, 2024

Conversation

shindigira
Copy link
Contributor

@shindigira shindigira commented May 3, 2024 •
edited
Loading

closes #444

Changes

How to Test

  • Upload a csv with errors or warnings or both
  • Go to the Errors or Warnings page
  • click on Download Validation Report
  • Verify the results

Screenshot

download validation report

@meissadia
fix: [axiosService] Add missing POST parameter
8688b34
@meissadia
[Filing Routing] Phase 1 - Mock Filing progress
6822d26
@meissadia
[Filing Routing] Phase 1 - Separate routes per step
9849158
@meissadia
fix: axiosService.request - remove unneeded data param in favor of …
fea91e3 
…`body`
@meissadia
fix: useMemo to avoid duplicate placeholder objects being generated
46971d5
@meissadia
fix: FilingStepWrapper.helpers - remove unused eslint rule disables
2c2de5f
@meissadia
[Filing Routing] Phase 1 - Mock Filing progress
bc14e84
@meissadia
[Filing Routing] Phase 1 - Separate routes per step
2cbd121
@meissadia
fix: useMemo to avoid duplicate placeholder objects being generated
e7d28d1
@meissadia
fix: FilingStepWrapper.helpers - remove unused eslint rule disables
9c52113
@meissadia
Update imports after rebase
d912fc7
@meissadia
Update imports after rebase part 2
9257eb7
@meissadia
Add "tasks" to our mock filing
c60e6e6
@meissadia
Sync axiosService file
2867e7b
@meissadia
Filing step - Display "current" highlight even if step is incomplete
cd9a385
@meissadia
Filing - Placeholder for "is step complete?" status
b937bc4
@meissadia
Filing step - Improve spacing between step indicators
5b6c4f3
@meissadia
Filing steps - Remove custom hook that contained routes, which helps …
c0be487 
…flatten the routing structure and hopefully simplify maintenance
@meissadia
Merge branch 'main' into 331-filing-routing_phase1-mock-data
f66f7b3
@meissadia
Filing steps - Revamp flex alignment of page elements
0c0d989
@meissadia
[ScreenReaderOnly] Component: Extract from Filing step indicator code…
cd69c7b 
… for reusability.
@meissadia
Filing steps - More dynamic routes (year and lei from the url)
e64c41c
@meissadia
Filing steps - Add TODO to check on StepIndicator widths
a0dcab9
@meissadia
Merge branch 'main' into 331-filing-routing_phase1-mock-data
74506f3
@meissadia
fix: [axiosService] Always include "body" for post/put/patch requests
f8f1bdc
@meissadia
feat: [API]
502c82c 
- Filing creation
- Rename fetchFilingSubmissionLatest to fetchSubmissionLatest
- Created useFilingAndSubmissionInfo
@meissadia
feat: [FilingOverview] Determine and link to next incomplete step
152ceb6
@meissadia
feat: [Filing] Display current Institution's progress within the subm…
4ebc759 
…ission process
@meissadia
feat: [Filing] Placeholder pages for Filing steps
a0fa68b
@meissadia
fix: [Institution card] Routing logic for a Submissio n with a previo…
77c7ea0 
…us upload
@shindigira
Merge branch '333-resolve-errors-warnings-skeleton-phase1' of github.…
ead5fad 
…com:cfpb/sbl-frontend into 444-download-validation-report
@shindigira shindigira mentioned this pull request May 6, 2024
Open
meissadia
meissadia requested changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and works for me!

Definitely want a way to differentiate downloaded validation reports between Submissions.

@shindigira
Merge branch 'main' of github.com:cfpb/sbl-frontend into 333-resolve-…
3e3e31d 
…errors-warnings-skeleton-phase1
@shindigira
step2 message fixed
6335396
@shindigira
Merge branch '333-resolve-errors-warnings-skeleton-phase1' of github.…
6d0c77d 
…com:cfpb/sbl-frontend into 444-download-validation-report
@shindigira
fixed isstep2 subheading on errors
3e20323
@shindigira
Merge branch '333-resolve-errors-warnings-skeleton-phase1' of github.…
4c68e16 
…com:cfpb/sbl-frontend into 444-download-validation-report
@shindigira
final isstep2 fix
931fd71
@shindigira
Merge branch '333-resolve-errors-warnings-skeleton-phase1' of github.…
d9c9453 
…com:cfpb/sbl-frontend into 444-download-validation-report
@shindigira
important: disable cache on validation reportsgit add src/api/request…
9be2923 
…s/downloadValidationReport.ts
@shindigira
submission id added to filename
9f5727f
@shindigira shindigira requested a review from meissadia May 6, 2024 23:09
@shindigira shindigira changed the base branch from 333-resolve-errors-warnings-skeleton-phase1 to main May 6, 2024 23:58
billhimmelsbach
billhimmelsbach approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok after our conversation this morning, things look good! Can we get a frontend ticket just to chat with Natalia about the design here? Just spinner hopefully.

@shindigira
Copy link
Contributor Author

Ok after our conversation this morning, things look good! Can we get a frontend ticket just to chat with Natalia about the design here? Just spinner hopefully.

#458

meissadia
meissadia approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@shindigira shindigira merged commit f38c1a0 into main May 7, 2024
2 checks passed
@billhimmelsbach billhimmelsbach deleted the 444-download-validation-report branch May 31, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meissadia meissadia meissadia approved these changes

@billhimmelsbach billhimmelsbach billhimmelsbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Resolve Errors/Warnings - Download Validation Report
3 participants
@shindigira @meissadia @billhimmelsbach