Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Design review] Sign and submit #435

Closed
wants to merge 80 commits into from
Closed

[Design review] Sign and submit #435

wants to merge 80 commits into from

Conversation

meissadia
Copy link
Collaborator

@meissadia meissadia commented May 1, 2024 •
edited
Loading

Pending items:

  • Beta: Are we going to show the final Sign and certify box in beta?
    • Yes, but the Submit button will remain disabled
  • Beta: Are we going to allow Submit?
    • No
  • Checkboxes: Content for labels
    • Design file updated, I need to integrate the changes
  • Register info: Live data for Total warning count
    • Total verified warnings: 1
    • Total warnings: 0
  • [Sign & submit] Integrate Total SBLAR count into page #450
  • Success alert: don't render
  • Success alert: Integrate live date and filename data
  • Total errors: 0 (zero comes from Submission)

Screenshots

screencapture-localhost-8899-filing-2024-123456789TESTBANK123-submit-2024-05-02-14_21_54

@meissadia
fix: [axiosService] Add missing POST parameter
8688b34
@meissadia
[Filing Routing] Phase 1 - Mock Filing progress
6822d26
@meissadia
[Filing Routing] Phase 1 - Separate routes per step
9849158
@meissadia
fix: axiosService.request - remove unneeded data param in favor of …
fea91e3 
…`body`
@meissadia
fix: useMemo to avoid duplicate placeholder objects being generated
46971d5
@meissadia
fix: FilingStepWrapper.helpers - remove unused eslint rule disables
2c2de5f
@meissadia
[Filing Routing] Phase 1 - Mock Filing progress
bc14e84
@meissadia
[Filing Routing] Phase 1 - Separate routes per step
2cbd121
@meissadia
fix: useMemo to avoid duplicate placeholder objects being generated
e7d28d1
@meissadia
fix: FilingStepWrapper.helpers - remove unused eslint rule disables
9c52113
@meissadia
Update imports after rebase
d912fc7
@meissadia
Update imports after rebase part 2
9257eb7
@meissadia
Add "tasks" to our mock filing
c60e6e6
@meissadia
Sync axiosService file
2867e7b
@meissadia
Filing step - Display "current" highlight even if step is incomplete
cd9a385
@meissadia
Filing - Placeholder for "is step complete?" status
b937bc4
@meissadia
Filing step - Improve spacing between step indicators
5b6c4f3
@meissadia
Filing steps - Remove custom hook that contained routes, which helps …
c0be487 
…flatten the routing structure and hopefully simplify maintenance
@meissadia
Merge branch 'main' into 331-filing-routing_phase1-mock-data
f66f7b3
@meissadia
Filing steps - Revamp flex alignment of page elements
0c0d989
@meissadia
[ScreenReaderOnly] Component: Extract from Filing step indicator code…
cd69c7b 
… for reusability.
@meissadia
Filing steps - More dynamic routes (year and lei from the url)
e64c41c
@meissadia
Filing steps - Add TODO to check on StepIndicator widths
a0dcab9
@meissadia
Merge branch 'main' into 331-filing-routing_phase1-mock-data
74506f3
@meissadia
fix: [axiosService] Always include "body" for post/put/patch requests
f8f1bdc
@meissadia
feat: [API]
502c82c 
- Filing creation
- Rename fetchFilingSubmissionLatest to fetchSubmissionLatest
- Created useFilingAndSubmissionInfo
@meissadia
feat: [FilingOverview] Determine and link to next incomplete step
152ceb6
@meissadia
feat: [Filing] Display current Institution's progress within the subm…
4ebc759 
…ission process
@meissadia
feat: [Filing] Placeholder pages for Filing steps
a0fa68b
@meissadia
fix: [Institution card] Routing logic for a Submissio n with a previo…
77c7ea0 
…us upload
@meissadia
task: [StepIndicator] remove duplicate styles
4878415
@meissadia
Merge branch 'main' into 331-filing-routing_phase2-live-data
4612751
@meissadia
task: Utilize some of the Design System colors that have been integra…
17b71eb 
…ted into our Tailwind config
@meissadia
fix: [useFilingAndSubmissionInfo] Ensure Filing is created before fet…
d661744 
…ching latest Submission
@meissadia
task: Use fetchFilingSubmissionLatest
963a7ca
@meissadia
Merge branch '331-filing-routing_phase2-live-data' into 400-sign-and-…
a8f3659 
…submit
@meissadia
task: [StepIndicator] remove duplicate styles
2f6d6a0
@meissadia
fix: [Sign & submit] Update content
474b2ad
@meissadia
feat: [Sign and submit] Add Success alert with mock data
4a50893
@meissadia
Merge branch '400-sign-and-submit' of https://github.com/cfpb/sbl-fro…
61903e7 
…ntend into 400-sign-and-submit
@meissadia
Merge main
bc51d70
@meissadia
Merge branch 'main' into 400-sign-and-submit
a27a65d
@meissadia
Merge branch 'main' into 400-sign-and-submit
66a71e4
@meissadia
task: design review
3ca8e52
@meissadia meissadia marked this pull request as ready for review May 1, 2024 15:57
@billhimmelsbach
Copy link
Contributor

TODO:

  • Ticket for what happens when people are done
  • Ticket for the total records
  • Screenshot?

@billhimmelsbach
Copy link
Contributor

billhimmelsbach commented May 6, 2024 •
edited
Loading

@natalia-fitzgerald

TODO:

  • content needs another review, @angelcardoz will be working on this and then messaging @meissadia
  • absolute bare minimum "submission" design (not submitting, just a static box saying thank you)

Base automatically changed from 400-sign-and-submit to main May 6, 2024 23:43
@meissadia
Copy link
Collaborator Author

Closing as stale. Will open new version when we're ready.

@meissadia meissadia closed this May 15, 2024
@meissadia meissadia deleted the design-review-sign-submit branch May 15, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billhimmelsbach billhimmelsbach Awaiting requested review from billhimmelsbach billhimmelsbach is a code owner

@shindigira shindigira Awaiting requested review from shindigira shindigira is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meissadia @billhimmelsbach @shindigira