Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protected Routes, Tailwind usage, Wildcard Routing -- Home/Filing #22

Merged
merged 5 commits into from
Aug 15, 2023

Conversation

shindigira
Copy link
Contributor

@shindigira shindigira commented Aug 14, 2023

Closes #20

Changes

  • Uses Protected Route (Logged-In user) code readability.
  • Converts non-design story styling to use Tailwind.
  • Wildcard routing (http://localhost:8881/kalsjdflkaj) should route to (http://localhost:8881/home)

How to Test

  • Test wildcard routing (e.g. http://localhost:8881/<whateverlongpath>. Should redirect to Home.
  • Logout and then test the redirects on Home and Filing. Do the same after logging in.
  • Run the app and then ensure no styling regressions in Home <FilingHome /> and Filing <FilingApp>.

Known Problem

Changes:
- [chore] Created a Protected Route and Redirect for the Filing page
Changes:
- [Chore] Converted styling to use Tailwind
@shindigira shindigira changed the title 20 filing home tailwind router Protected Routes & Tailwind usage -- Home/Filing Aug 14, 2023
@shindigira shindigira added the enhancement New feature or request label Aug 14, 2023
@shindigira shindigira changed the title Protected Routes & Tailwind usage -- Home/Filing Protected Routes, Tailwind usage, Wildcard Routing -- Home/Filing Aug 14, 2023
Copy link
Collaborator

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! 👍🏾

@meissadia
Copy link
Collaborator

There is one issue with the Login button no longer reflecting the CFPB DS styles. This is due to a bug in my recently implemented code that I've addressed here.

Once that's merged we can cut a new release of the DS React and integrate it into this repo.

Screenshot 2023-08-14 at 2 24 11 PM

@contolini
Copy link
Member

There is one issue with the Login button no longer reflecting the CFPB DS styles. This is due to a bug in my recently implemented code that I've addressed here.

Once that's merged we can cut a new release of the DS React and integrate it into this repo.

I merged it and tagged a release (0.0.5) but how would y'all feel about just importing the main branch while we're in this rapid development phase? @shindigira if you yarn add design-stories@cfpb/design-stories it'll install the main branch and the button styles should be fixed.

@shindigira
Copy link
Contributor Author

shindigira commented Aug 15, 2023

@contolini Updated with the design-stories updates and the problem(s) are resolved!

@shindigira shindigira merged commit da3fd48 into main Aug 15, 2023
1 of 2 checks passed
@meissadia meissadia deleted the 20-filing-home-tailwind-router branch September 22, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chore] Filing Home - Tailwind and React-Router adjustments
3 participants