added phone extension to Verification field on sign and submit, updat…

…ed e2e tests
cfpb · Sep 25, 2024 · 8f50bca · 8f50bca
1 parent df2ce2b
commit 8f50bca
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 0 deletions.
diff --git a/e2e/example.spec.demo.ts b/e2e/example.spec.demo.ts
@@ -100,6 +100,9 @@ test('proof of concept', async ({ page }) => {
       await page
         .getByLabel('Work phone numberPhone number')
         .fill(pointOfContactJson.phone_number);
+      await page
+        .getByLabel('Extension (optional)Extension')
+        .fill(pointOfContactJson.phone_ext);
       await page
         .getByLabel('Email addressEmail address')
         .fill(pointOfContactJson.email);

diff --git a/e2e/fixtures/testFixture.ts b/e2e/fixtures/testFixture.ts
@@ -258,6 +258,7 @@ export const test = baseTest.extend<{
       await page.getByRole('button', { name: 'Continue to next step' }).click();
       await expect(page.locator('h1')).toContainText(
         'Provide point of contact',
+        { timeout: 30_000 },
       );
     });
     await use(page);
@@ -275,6 +276,9 @@ export const test = baseTest.extend<{
         await page
           .getByLabel('Work phone numberPhone number')
           .fill(pointOfContactJson.phone_number);
+        await page
+          .getByLabel('Extension (optional)Extension')
+          .fill(pointOfContactJson.phone_ext);
         await page
           .getByLabel('Email addressEmail address')
           .fill(pointOfContactJson.email);

diff --git a/e2e/test-data/point-of-contact/point-of-contact-data-1.json b/e2e/test-data/point-of-contact/point-of-contact-data-1.json
@@ -9,5 +9,6 @@
   "hq_address_state": "CA",
   "hq_address_zip": "55555",
   "phone_number": "555-555-5555",
+  "phone_ext": "8942",
   "email": "point_of_contact_email@email.test"
 }
diff --git a/src/pages/Filing/FilingApp/FilingSubmit.helpers.tsx b/src/pages/Filing/FilingApp/FilingSubmit.helpers.tsx
@@ -53,6 +53,7 @@ export function PointOfContactConfirm({
         <DisplayField label='Last name' value={poc?.last_name} />
         <DisplayField label='Email address' value={poc?.email} />
         <DisplayField label='Work phone number' value={poc?.phone_number} />
+        <DisplayField label='Work phone extension' value={poc?.phone_ext} />
         <DisplayField
           label='Business address'
           value={

diff --git a/src/types/filingTypes.ts b/src/types/filingTypes.ts
@@ -79,6 +79,7 @@ export const FilingSchema = z.object({
       hq_address_zip: z.string(),
       email: z.string(),
       phone_number: z.string(),
+      phone_ext: z.string(),
     }),
     z.null(),
   ]),

diff --git a/src/types/formTypes.ts b/src/types/formTypes.ts
@@ -380,6 +380,7 @@ export const ContactInfoMap = {
   first_name: 'firstName',
   last_name: 'lastName',
   phone_number: 'phone',
+  phone_ext: 'phoneExtension',
   email: 'email',
   hq_address_street_1: 'hq_address_street_1',
   hq_address_street_2: 'hq_address_street_2',