Extend step activity with information about exception

cezarypiatek · Nov 6, 2024 · face624 · face624
1 parent 6a3f07d
commit face624
Showing 1 changed file with 34 additions and 2 deletions.
diff --git a/src/NScenario/StepExecutors/InstrumentationScenarioStepExecutor.cs b/src/NScenario/StepExecutors/InstrumentationScenarioStepExecutor.cs
@@ -22,12 +22,44 @@ public InstrumentationScenarioStepExecutor(IScenarioStepExecutor scenarioStepExe
     public async Task Step(string scenarioName, string stepDescription, Func<Task> action, StepContext stepContext)
     {
         using var activity = NScenarioInstrumentation.DiagnosticSource.StartActivity(name: stepDescription);
-        await _scenarioStepExecutorImplementation.Step(scenarioName, stepDescription, action, stepContext);
+        try
+        {
+            await _scenarioStepExecutorImplementation.Step(scenarioName, stepDescription, action, stepContext);
+        }
+        catch (Exception e)
+        {
+            TryToMarkActivityAsFailed(activity, e);
+            throw;
+        }
+    }
+
+    private static void TryToMarkActivityAsFailed(Activity? activity, Exception e)
+    {
+        if (activity != null)
+        {
+            activity.AddEvent(new ActivityEvent("exception",tags: new ActivityTagsCollection
+            {
+                ["operation.status"] = "failed",
+                ["exception.escaped"] = true,
+                ["exception.type"] = e.GetType().ToString(),
+                ["exception.message"] = e.Message,
+                ["exception.stacktrace"] = e.StackTrace
+            }));
+            activity.SetStatus(ActivityStatusCode.Error, e.Message);
+        }
     }
 
     public async Task Step(string scenarioName, string stepDescription, Action action, StepContext stepContext)
     {
         using var activity = NScenarioInstrumentation.DiagnosticSource.StartActivity(name: stepDescription);
-        await _scenarioStepExecutorImplementation.Step(scenarioName, stepDescription, action, stepContext);
+        try
+        {
+            await _scenarioStepExecutorImplementation.Step(scenarioName, stepDescription, action, stepContext);
+        }
+        catch (Exception e)
+        {
+            TryToMarkActivityAsFailed(activity, e);
+            throw;
+        }
     }
 }