Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of stuff! See below #26

Closed
wants to merge 28 commits into from
Closed

Conversation

octoshrimpy
Copy link
Contributor

  • Config version bump:

    • automatically upgrades old config versions
    • does not lose any of the previous values
    • includes a new theme system User Themes #22
  • Adds transparency option: background passthrough if the term supports it

  • Adds support for x256 colors

  • Adds playlist playing icon

  • adds device currently playing icon

  • check if spotify is playing (necessary for the icons logic)

  • get all playlists, not just first 50 Playlists capped at 50  #21

  • normalized selected cursor length highlight in playlist screen

  • better text padding mechanics

  • better truncate mechanics. both of these now support doublebyte characters, like kanji!

@ceuk
Copy link
Owner

ceuk commented Jun 11, 2021

Wow! 😁 I'll start going through now, might have to do it in two sittings 😅

Copy link
Owner

@ceuk ceuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@octoshrimpy I've split out the playlist stuff into a separate PR (#27) as this might take a while to get merged and I know @diegoulloao is waiting for the fix :) This way we can deal with that one separately - looks fine subject to a quick test (see below)

I've also split up the rest of the commits into two sections:

#29 General improvements
#28 Theme support (and config improvements)

I've invited you as a collaborator to the repo so you should be able to make changes to these new PRs

spotui/src/spotifyApi.py Show resolved Hide resolved
This was referenced Jun 11, 2021
@ceuk ceuk closed this Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants