Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle null block error in rpc-eth-client #477

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Handle null block error in rpc-eth-client #477

merged 3 commits into from
Nov 17, 2023

Conversation

nikugogoi
Copy link
Collaborator

Part of Refactoring and cleanup in watcher-ts

  • Remove block-size-cache methods as full block with size data is already fetched at start of block processing
  • Handle null block error in rpc-eth-client and return null value in blocks array

@nikugogoi nikugogoi self-assigned this Nov 17, 2023
@nikugogoi nikugogoi changed the title [WIP] Handle null block error in rpc-eth-client Handle null block error in rpc-eth-client Nov 17, 2023
@ashwinphatak ashwinphatak merged commit c2070a8 into main Nov 17, 2023
2 checks passed
@ashwinphatak ashwinphatak deleted the ng-eth-client-null-block branch November 17, 2023 06:28
@nikugogoi nikugogoi mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikugogoi nikugogoi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikugogoi @ashwinphatak