Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

Commit

Permalink
fix(config): Regression fixed with a backport.
Browse files Browse the repository at this point in the history
  • Loading branch information
bouda1 committed Apr 22, 2021
1 parent 8d7afc6 commit 7bdf626
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 6 deletions.
11 changes: 10 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@

### Bugfixes

*Config*

retry_interval attribute in configuration file seems to be have a safe behavior with a
decimal value, but but with a chain of character broker quit without understanble error message,
now broker quits cleanly with a warning that we can see in by using journalctl command.


*TCP*

Expand Down Expand Up @@ -38,14 +44,17 @@ Now '.' is allowed in names.
When broker is badly configured and the user wants to stop it, it may hang and
never stop. This new version fixes this issue.

There were also dangling pointers in the bbdo manager that regularly lead to
segfault when it was unloaded. It is fixed now.

*Storage rebuilder*

The rebuilder loop has been rewritten. When it is stopped, it is interrupted
correctly.

*Logs*

The new logs (log_v2) are correctly flushed when cbd is stopped.
The new logs (log\_v2) are correctly flushed when cbd is stopped.

*Thread pool*

Expand Down
2 changes: 1 addition & 1 deletion core/src/bbdo/stream.cc
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ static uint32_t set_uint(io::data& t,
}

/**
* Set an uint32_teger within an object.
* Set an uint64_teger within an object.
*/
static uint32_t set_ulong(io::data& t,
mapping::entry const& member,
Expand Down
2 changes: 1 addition & 1 deletion core/src/compression/stream.cc
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ bool stream::read(std::shared_ptr<io::data>& data, time_t deadline) {
// Process buffer as long as data is corrupted
// or until an exception occurs.
bool corrupted(true);
int size(0);
size_t size(0);
int skipped(0);
while (corrupted) {
// Get compressed data length.
Expand Down
5 changes: 2 additions & 3 deletions core/src/config/parser.cc
Original file line number Diff line number Diff line change
Expand Up @@ -252,9 +252,8 @@ void parser::_parse_endpoint(Json const& elem, endpoint& e) {
e.retry_interval =
static_cast<uint32_t>(std::stoul(object.second.string_value()));
} catch (const std::exception& e) {
throw msg_fmt(
"config parser: cannot parse key "
"'retry_interval': value must be an integer");
throw exceptions::msg() << "config parser: cannot parse key "
"'retry_interval': value must be an integer";
}
else if (object.first == "filters") {
std::set<std::string> endpoint::*member;
Expand Down

0 comments on commit 7bdf626

Please sign in to comment.