Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta Version #1

Merged
merged 8 commits into from
Jun 6, 2024
Merged

Beta Version #1

merged 8 commits into from
Jun 6, 2024

Conversation

courtneyhasss
Copy link
Contributor

Version for review by participants

initial draft
Update to graphics, pages, and video placeholders
@courtneyhasss courtneyhasss requested a review from mehaase June 4, 2024 14:58
@mehaase mehaase reopened this Jun 4, 2024
fix warnings - update 6/4
update question 2 formatting
Copy link

github-actions bot commented Jun 4, 2024

This PR has been published to https://ctidthreatmodeling.z13.web.core.windows.net/Draft/

Copy link
Contributor

@mehaase mehaase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is looking good. I left a comments and requests. Once those are addressed, I will merge this PR.

docs/conf.py Outdated Show resolved Hide resolved
docs/question-1.rst Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
docs/question-2.rst Outdated Show resolved Hide resolved

.. raw:: html

<p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When will these navigator layers be ready? It looks like they've already been created, no? Can you add them to this PR and update the HREFs below, or is there a compelling reason to do that later?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these links will be updated this week

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

layers are available for download, working on links to open in navigator. Those should be addressed this week

docs/question-1.rst Show resolved Hide resolved

.. raw:: html

<iframe width="560" height="315" src="https://www.youtube.com/embed/h_BC6QMWDbA?si=Abpy35U4SYKMYUeE" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" referrerpolicy="strict-origin-when-cross-origin" allowfullscreen></iframe>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a temporary YouTube URL? I.e. this will be replaced with one of the videos that you made?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a temporary video until we get videos back

docs/question-3.rst Outdated Show resolved Hide resolved
docs/question-3.rst Outdated Show resolved Hide resolved
docs/additional-resources.rst Outdated Show resolved Hide resolved
updates based on feedback from Mark
fix warnings and add download for layers
Copy link

github-actions bot commented Jun 6, 2024

This PR has been published to https://ctidthreatmodeling.z13.web.core.windows.net/Draft/

Copy link
Contributor

@mehaase mehaase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@mehaase mehaase merged commit ea4b0e7 into main Jun 6, 2024
2 checks passed
@mehaase mehaase deleted the Draft branch June 6, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants