-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta Version #1
Beta Version #1
Conversation
Update to graphics, pages, and video placeholders
fix warnings - update 6/4
update question 2 formatting
fix warning
This PR has been published to https://ctidthreatmodeling.z13.web.core.windows.net/Draft/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is looking good. I left a comments and requests. Once those are addressed, I will merge this PR.
|
||
.. raw:: html | ||
|
||
<p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When will these navigator layers be ready? It looks like they've already been created, no? Can you add them to this PR and update the HREFs below, or is there a compelling reason to do that later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these links will be updated this week
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
layers are available for download, working on links to open in navigator. Those should be addressed this week
|
||
.. raw:: html | ||
|
||
<iframe width="560" height="315" src="https://www.youtube.com/embed/h_BC6QMWDbA?si=Abpy35U4SYKMYUeE" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" referrerpolicy="strict-origin-when-cross-origin" allowfullscreen></iframe> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a temporary YouTube URL? I.e. this will be replaced with one of the videos that you made?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a temporary video until we get videos back
updates based on feedback from Mark
This PR has been published to https://ctidthreatmodeling.z13.web.core.windows.net/Draft/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Version for review by participants