Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate removing extraneous fields from BlevmAggOutput #120

Open
rootulp opened this issue Jan 30, 2025 · 0 comments
Open

Investigate removing extraneous fields from BlevmAggOutput #120

rootulp opened this issue Jan 30, 2025 · 0 comments

Comments

@rootulp
Copy link
Collaborator

rootulp commented Jan 30, 2025

Context

#[derive(Serialize, Deserialize)]
pub struct BlevmAggOutput {
// newest_header_hash is the last block's hash on the EVM roll-up.
// TODO: this may be removable.
pub newest_header_hash: [u8; 32],
// oldest_header_hash is the earliest block's hash on the EVM roll-up.
// TODO: this may be removable.
pub oldest_header_hash: [u8; 32],
// celestia_header_hashes is the range of Celestia blocks that include all
// of the blob data the EVM roll-up has posted from oldest_header_hash to
// newest_header_hash.
pub celestia_header_hashes: Vec<[u8; 32]>, // provided by Celestia state machine (eventually x/header)
// newest_state_root is the computed state root of the EVM roll-up after
// processing blocks from oldest_header_hash to newest_header_hash.
pub newest_state_root: [u8; 32],
// newest_height is the most recent block number of the EVM roll-up.
// TODO: this may be removable.
pub newest_height: u64,
}

Problem

3 of those fields may be removable.

Proposal

Investigate if they can be removed. Remove them if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant