Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transport): add valkey and valkeys #2246

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Zerotask
Copy link

@Zerotask Zerotask commented Feb 18, 2025

This PR adds the alternative transport schemes valkey and valkeys, which is also the recommendation from django-valkey.

Fixes #2245

I didn't update the documentation because I first want to get feedback.
There could be a new page for Valkey or just an addition for the Redis transport here:
https://docs.celeryq.dev/projects/kombu/en/stable/reference/kombu.transport.redis.html


Valkey is an open source drop-in replacement for Redis:

This project was forked from the open source Redis project right before the transition to their new source available licenses.
(https://github.com/valkey-io/valkey)

https://django-valkey.readthedocs.io/en/latest/configure/advanced_configurations.html

Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zerotask
Copy link
Author

See celery/celery#9300

Thank you for referencing that. So this is a blocker and it probably needs a new Valkey transport implementation in kombu?

We recently switched from Redis to Valkey and didn't experience any issues with celery. It works as before.

@Nusnus
Copy link
Member

Nusnus commented Feb 18, 2025

See celery/celery#9300

Thank you for referencing that. So this is a blocker and it probably needs a new Valkey transport implementation in kombu?

We recently switched from Redis to Valkey and didn't experience any issues with celery. It works as before.

I don't recall all of the details, but the other issue explains where we are right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Valkey
2 participants