Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Django Transport #2228

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Create Django Transport #2228

wants to merge 8 commits into from

Conversation

thuibr
Copy link

@thuibr thuibr commented Jan 18, 2025

Add Django ORM transport. This coincides with celery/celery#9500

Django Transport module for kombu.

Kombu transport using Django ORM as the message store.

Features
========
* Type: Virtual
* Supports Direct: Yes
* Supports Topic: Yes
* Supports Fanout: Yes
* Supports Priority: Yes
* Supports TTL: Yes

Connection String
=================

.. code-block::

    django:///

Tested with sqlite and postgres. Also, flower is working reasonably well.

This effort is inspired by Oban for Elixir and River for Go.

@thuibr thuibr marked this pull request as draft January 18, 2025 16:15
@thuibr thuibr marked this pull request as ready for review January 18, 2025 17:52
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 92.37288% with 9 lines in your changes missing coverage. Please review.

Project coverage is 81.67%. Comparing base (a9a67c9) to head (fe1d602).

Files with missing lines Patch % Lines
kombu/transport/django/transport.py 90.14% 7 Missing ⚠️
kombu/transport/django/models.py 93.93% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2228      +/-   ##
==========================================
+ Coverage   81.54%   81.67%   +0.12%     
==========================================
  Files          77       82       +5     
  Lines        9517     9635     +118     
  Branches     1154     1160       +6     
==========================================
+ Hits         7761     7869     +108     
- Misses       1564     1574      +10     
  Partials      192      192              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thuibr thuibr force-pushed the main branch 10 times, most recently from 357ecd5 to 3fd61a0 Compare January 19, 2025 17:15
@thuibr thuibr marked this pull request as draft January 19, 2025 17:17
@thuibr thuibr force-pushed the main branch 2 times, most recently from 2b6ac41 to 4df3ff8 Compare January 19, 2025 22:23
@thuibr thuibr marked this pull request as ready for review January 19, 2025 22:23
@thuibr thuibr force-pushed the main branch 7 times, most recently from 136aeb1 to cec7b95 Compare January 20, 2025 13:51
@thuibr thuibr force-pushed the main branch 3 times, most recently from c822688 to 0986639 Compare January 20, 2025 21:42
@auvipy auvipy self-requested a review January 29, 2025 04:52
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accept the premise of this PR. but I want to take some time to properly review it

@Nusnus Nusnus self-requested a review February 4, 2025 00:57
@auvipy auvipy added this to the 5.6.0 milestone Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants