-
-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix redis health checks #1122
Fix redis health checks #1122
Conversation
91889cb
to
c3a45b7
Compare
python 3 tests are faiing |
c3a45b7
to
5fec5b7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1122 +/- ##
==========================================
+ Coverage 88.79% 88.82% +0.02%
==========================================
Files 65 65
Lines 6767 6780 +13
Branches 813 815 +2
==========================================
+ Hits 6009 6022 +13
Misses 665 665
Partials 93 93
Continue to review full report at Codecov.
|
5fec5b7
to
b530d5b
Compare
@auvipy Please review this PR, thanks! |
85ec678
to
7d59889
Compare
7d59889
to
f55b74e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you have time, can you also add some integration tests?
I tried installing celery from master (https://github.com/celery/celery.git) and kombu from #1122 (https://github.com/LeetCode-OpenSource/kombu.git) and can confirm that a minimal check like that mentioned here does not throw an exception. |
Hm, I'll try to look into integration tests this weekend. |
any update on integration tests? |
I did check up integration tests some time ago but there was more amount of work needed on that. So, I couldn't finish them up. I would like someone else to take that task. |
Description
Fixes #1019
#1113 didn't set
health_check_interval
parameter due to which calling health_check on the underlying redis client become no-op.Testing
I have tested this branch on my setup and seems to work fine, I'm able to receive
"PING" "redis-py-health-check"
messages in redis monitor.Though I haven't tested
SentinelChannel
. As far as I can see, it won't work on Sentinel but at least won't be crashing it out. I don't plan to add support for Sentinel since I won't be able to test it out.Other than that, I have handled it for both newer as well as older redis python clients.