Add safety visualization tool #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
enhancement
Test summary 4 554 files 6 992 suites 13m 23s ⏱️ Results for commit 663ad0d. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a utility that writes a JSON file containing safety distance calculations for every point in a 2D slice. I've used it to compare ORANGE safety against VecGeom/Geant4, and also verify https://its.cern.ch/jira/browse/VECGEOM-522 . We can use this to help verify future safety implementations in ORANGE (#990) and the surface-based VecGeom 2.0 (#1412).
Once this is merged I'll add plotting tools to celerpy (currently it resides in a notebook in the benchmark repo).
Here is a "material scan" (raytrace) and safety distance of the CMSE region measured from Geant4:
and calculated with the known-broken VecGeom 1.2.8:
and finally recalculated with the fixed VecGeom 1.2.9
See #844 (comment)