Add JLSE CMake preset and a few small fixes #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In file included from /soft/compilers/gcc/12.2.0/x86_64-suse-linux/include/c++/12.2.0/string:40,
from /home/alund/celeritas_project/celeritas/src/corecel/io/Label.hh:12,
from /home/alund/celeritas_project/celeritas/test/corecel/io/Label.test.cc:7:
In static member function ‘static constexpr int std::char_traits<char>::compare(const char_type*, const char_type*, std::size_t)’,
inlined from ‘int std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::compare(const std::__cxx11::basic_string<_CharT, _Traits, _Alloc>&) const [with _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]’ at /soft/compilers/gcc/12.2.0/x86_64-suse-linux/include/c++/12.2.0/bits/basic_string.h:3148:32,
inlined from ‘bool std::operator<(const __cxx11::basic_string<_CharT, _Traits, _Allocator>&, const __cxx11::basic_string<_CharT, _Traits, _Allocator>&) [with _CharT = char; _Traits = char_traits<char>; _Alloc = allocator<char>]’ at /soft/compilers/gcc/12.2.0/x86_64-suse-linux/include/c++/12.2.0/bits/basic_string.h:3694:27,
inlined from ‘bool celeritas::operator<(const Label&, const Label&)’ at /home/alund/celeritas_project/celeritas/src/corecel/io/Label.hh:98:17,
inlined from ‘bool celeritas::operator<(const Label&, const Label&)’ at /home/alund/celeritas_project/celeritas/src/corecel/io/Label.hh:92:13,
inlined from ‘virtual void celeritas::test::LabelTest_ordering_Test::TestBody()’ at /home/alund/celeritas_project/celeritas/test/corecel/io/Label.test.cc:28:5:
/soft/compilers/gcc/12.2.0/x86_64-suse-linux/include/c++/12.2.0/bits/char_traits.h:385:32: error: ‘*(const unsigned char*)((char*)&<unnamed> + offsetof(celeritas::Label, celeritas::Label::ext.std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::<unnamed>))’ may be used uninitialized [-Werror=maybe-uninitialized]
385 | return __builtin_memcmp(__s1, __s2, __n);
| ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
In file included from /home/alund/spack/var/spack/environments/celeritas/.spack-env/view/include/gtest/gtest-printers.h:122,
from /home/alund/spack/var/spack/environments/celeritas/.spack-env/view/include/gtest/gtest-matchers.h:49,
from /home/alund/spack/var/spack/environments/celeritas/.spack-env/view/include/gtest/internal/gtest-death-test-internal.h:47,
from /home/alund/spack/var/spack/environments/celeritas/.spack-env/view/include/gtest/gtest-death-test.h:43,
from /home/alund/spack/var/spack/environments/celeritas/.spack-env/view/include/gtest/gtest.h:64,
from /home/alund/celeritas_project/celeritas/test/Test.hh:12,
from /home/alund/celeritas_project/celeritas/test/celeritas_test.hh:16,
from /home/alund/celeritas_project/celeritas/test/corecel/io/Label.test.cc:9:
/home/alund/celeritas_project/celeritas/test/corecel/io/Label.test.cc: In member function ‘virtual void celeritas::test::LabelTest_ordering_Test::TestBody()’:
/home/alund/celeritas_project/celeritas/test/corecel/io/Label.test.cc:28:50: note: ‘<anonymous>’ declared here
28 | EXPECT_FALSE(Label("a", "2") < Label("a", "1"));
| ^
amandalund
added
documentation
Test summary 1 953 files 3 069 suites 1m 6s ⏱️ Results for commit b30d740. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.