Support for Multiple Currencies and Currency Symbols #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope you're doing well. I've created a pull request that adds support for multiple currencies and their corresponding currency symbols. This enhancement resolves the issue of returning None when accessing a price currency which is not $.
Here's a summary of the changes:
Added a list, CURRENCY_SYMBOLS_LIST, to the flight.py file, which contains various currency symbols.
Added price_currency property from the Flight class.
Updated the _classify_arg method in the Flight class to extract the currency symbol directly from the argument.
Modified the data frame creation in the Flight.get_dataframe method of the scrape.py file to use a dynamic price column name, "Price (CURRENCY_SYMBOL)".
These changes make the library more robust and user-friendly, as it now supports different currencies and provides accurate currency symbols.
Please review the pull request at your convenience. I'm open to any feedback or suggestions for improvement.
Thank you for your time and consideration.