Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Alloy Bootstrap (M128) #4795

Closed
amaitland opened this issue May 6, 2024 · 11 comments
Closed

Remove Alloy Bootstrap (M128) #4795

amaitland opened this issue May 6, 2024 · 11 comments
Assignees
Labels
breaking-change upstream These issues require fixing in the Chromium Embedded Framework(CEF) or Chromium.
Milestone

Comments

@amaitland
Copy link
Member

amaitland commented May 6, 2024

CEF is going to remove the Alloy Bootstrap

Starting in M125 it will be possible to migrate over to the Chrome Bootstrap.

@amaitland amaitland self-assigned this May 6, 2024
@amaitland
Copy link
Member Author

CefSharp will likely switch to using the Chrome Bootstrap by default in M126 to ensure any underlying issues are identified before the alloy bootstrap is removed.

@amaitland
Copy link
Member Author

CefSharp will likely switch to using the Chrome Bootstrap by default in M126 to ensure any underlying issues are identified before the alloy bootstrap is removed.

Confirming this change (#4835)

@amaitland
Copy link
Member Author

amaitland commented Jun 27, 2024

Important

If you discover an issue with the Chrome Bootstrap then you need to raise the issue on the CEF ISSUE TRACKER

https://github.com/chromiumembedded/cef/issues

Please post a link to the upstream issue below so it can be added to the list, don't create an issue in this repository.

@amaitland amaitland added the upstream These issues require fixing in the Chromium Embedded Framework(CEF) or Chromium. label Jun 28, 2024
@amaitland amaitland changed the title Remove Alloy Bootstrap Remove Alloy Bootstrap (M128) Jul 2, 2024
@amaitland
Copy link
Member Author

The Alloy bootstrap will be removed upstream in M128

@amaitland
Copy link
Member Author

The disable-pdf-extension flag is not supported with Chrome bootstrap.

@amaitland
Copy link
Member Author

amaitland commented Jul 21, 2024

@amaitland
Copy link
Member Author

The disable-pdf-extension flag is not supported with Chrome bootstrap.

Workaround chromiumembedded/cef#3739 (comment)

@amaitland amaitland added this to the 128.4.x milestone Sep 19, 2024
amaitland added a commit that referenced this issue Sep 19, 2024
@mattwildgoose
Copy link

Submitting a form with newly entered address details causes the hosting app to crash (if CefSettings.Locale is set)

@mol
Copy link
Contributor

mol commented Dec 29, 2024

@amaitland chromiumembedded/cef#3860 means WPF has this issue, since as I understand it, WPF is still using Alloy.

I've searched everywhere, but I'm unclear what the eventual complete removal of Alloy in CEF is going to mean for CefSharp WPF? Will the Chrome Bootstrap support WPF?

@amaitland
Copy link
Member Author

My understanding there's two parts, bootstrap and style. The alloy bootstrap has already been removed. The chrome bootstrap is the only option now.

The chrome bootstrap supports alloy styling. OSR which the WPF implementation uses is only supported with alloy styling.

I'm not aware of any plans to remove alloy styled browsers. If you're seen something to the contrary then please share a link.

There are a number of issues that you might run into with the OSR implementation as it stands, the key ones being

chromiumembedded/cef#3826
chromiumembedded/cef#3822
chromiumembedded/cef#3764

There is the hwndhost implementation which can be configured to use chrome styling. (Airspace issues apply) https://github.com/cefsharp/CefSharp.Wpf.HwndHost

I'm not sure if this is viable for you as an alternative, just pointing it out just in case.

I'm in the process of moving the source into the main repo #4981

@mol
Copy link
Contributor

mol commented Dec 30, 2024

My understanding there's two parts, bootstrap and style. The alloy bootstrap has already been removed. The chrome bootstrap is the only option now.

Ah, I see. I wasn't fully aware of this distinction - good to know, thanks.

Thanks for the other links - I'll play around with it some more and see what I can find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change upstream These issues require fixing in the Chromium Embedded Framework(CEF) or Chromium.
Projects
None yet
Development

No branches or pull requests

3 participants