Skip to content

Commit

Permalink
Upgrade to 126.1.14+g2be337f+chromium-126.0.6478.57 / Chromium 126.0.…
Browse files Browse the repository at this point in the history
…6478.57

- IDialogHandler.OnFileDialog add new extensions and descriptions arguments (Breaking Change)

Resolves #4838
  • Loading branch information
amaitland committed Jun 15, 2024
1 parent 3ff0c36 commit ed6a983
Show file tree
Hide file tree
Showing 35 changed files with 83 additions and 53 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="..\packages\cef.sdk.125.0.21\build\cef.sdk.props" Condition="Exists('..\packages\cef.sdk.125.0.21\build\cef.sdk.props')" />
<Import Project="..\packages\cef.sdk.126.1.14\build\cef.sdk.props" Condition="Exists('..\packages\cef.sdk.126.1.14\build\cef.sdk.props')" />
<Import Project="..\packages\Microsoft.SourceLink.GitHub.1.0.0\build\Microsoft.SourceLink.GitHub.props" Condition="Exists('..\packages\Microsoft.SourceLink.GitHub.1.0.0\build\Microsoft.SourceLink.GitHub.props')" />
<Import Project="..\packages\Microsoft.SourceLink.Common.1.0.0\build\Microsoft.SourceLink.Common.props" Condition="Exists('..\packages\Microsoft.SourceLink.Common.1.0.0\build\Microsoft.SourceLink.Common.props')" />
<Import Project="..\packages\Microsoft.Build.Tasks.Git.1.0.0\build\Microsoft.Build.Tasks.Git.props" Condition="Exists('..\packages\Microsoft.Build.Tasks.Git.1.0.0\build\Microsoft.Build.Tasks.Git.props')" />
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build" ToolsVersion="12.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="..\packages\cef.sdk.125.0.21\build\cef.sdk.props" Condition="Exists('..\packages\cef.sdk.125.0.21\build\cef.sdk.props')" />
<Import Project="..\packages\cef.sdk.126.1.14\build\cef.sdk.props" Condition="Exists('..\packages\cef.sdk.126.1.14\build\cef.sdk.props')" />
<Import Project="..\packages\Microsoft.SourceLink.GitHub.1.0.0\build\Microsoft.SourceLink.GitHub.props" Condition="Exists('..\packages\Microsoft.SourceLink.GitHub.1.0.0\build\Microsoft.SourceLink.GitHub.props')" />
<Import Project="..\packages\Microsoft.SourceLink.Common.1.0.0\build\Microsoft.SourceLink.Common.props" Condition="Exists('..\packages\Microsoft.SourceLink.Common.1.0.0\build\Microsoft.SourceLink.Common.props')" />
<Import Project="..\packages\Microsoft.Build.Tasks.Git.1.0.0\build\Microsoft.Build.Tasks.Git.props" Condition="Exists('..\packages\Microsoft.Build.Tasks.Git.1.0.0\build\Microsoft.Build.Tasks.Git.props')" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ namespace CefSharp
{
auto propertyAttribute = javascriptProperty->IsReadOnly ? V8_PROPERTY_ATTRIBUTE_READONLY : V8_PROPERTY_ATTRIBUTE_NONE;

v8Value->SetValue(propertyName, V8_ACCESS_CONTROL_DEFAULT, propertyAttribute);
v8Value->SetValue(propertyName, propertyAttribute);
}
};
}
Expand Down
8 changes: 4 additions & 4 deletions CefSharp.BrowserSubprocess.Core/Resource.rc
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#pragma code_page(65001)

1 VERSIONINFO
FILEVERSION 125,0,210
PRODUCTVERSION 125,0,210
FILEVERSION 126,1,140
PRODUCTVERSION 126,1,140
FILEFLAGSMASK 0x17L
#ifdef _DEBUG
FILEFLAGS 0x1L
Expand All @@ -18,10 +18,10 @@ BEGIN
BLOCK "040904b0"
BEGIN
VALUE "FileDescription", "CefSharp.BrowserSubprocess.Core"
VALUE "FileVersion", "125.0.210"
VALUE "FileVersion", "126.1.140"
VALUE "LegalCopyright", "Copyright © 2023 The CefSharp Authors"
VALUE "ProductName", "CefSharp"
VALUE "ProductVersion", "125.0.210"
VALUE "ProductVersion", "126.1.140"
END
END
BLOCK "VarFileInfo"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="cef.sdk" version="125.0.21" targetFramework="native" />
<package id="cef.sdk" version="126.1.14" targetFramework="native" />
<package id="Microsoft.Build.Tasks.Git" version="1.0.0" targetFramework="native" developmentDependency="true" />
<package id="Microsoft.SourceLink.Common" version="1.0.0" targetFramework="native" developmentDependency="true" />
<package id="Microsoft.SourceLink.GitHub" version="1.0.0" targetFramework="native" developmentDependency="true" />
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="cef.sdk" version="125.0.21" targetFramework="netcoreapp3.1" />
<package id="cef.sdk" version="126.1.14" targetFramework="netcoreapp3.1" />
<package id="Microsoft.Build.Tasks.Git" version="1.0.0" targetFramework="native" developmentDependency="true" />
<package id="Microsoft.SourceLink.Common" version="1.0.0" targetFramework="native" developmentDependency="true" />
<package id="Microsoft.SourceLink.GitHub" version="1.0.0" targetFramework="native" developmentDependency="true" />
Expand Down
2 changes: 1 addition & 1 deletion CefSharp.BrowserSubprocess/app.manifest
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
xmlns:asmv3="urn:schemas-microsoft-com:asm.v3"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">

<assemblyIdentity version="125.0.210.0" name="CefSharp.BrowserSubprocess.app" />
<assemblyIdentity version="126.1.140.0" name="CefSharp.BrowserSubprocess.app" />
<trustInfo xmlns="urn:schemas-microsoft-com:asm.v2">
<security>
<requestedPrivileges xmlns="urn:schemas-microsoft-com:asm.v3">
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="..\packages\cef.sdk.125.0.21\build\cef.sdk.props" Condition="Exists('..\packages\cef.sdk.125.0.21\build\cef.sdk.props')" />
<Import Project="..\packages\cef.sdk.126.1.14\build\cef.sdk.props" Condition="Exists('..\packages\cef.sdk.126.1.14\build\cef.sdk.props')" />
<Import Project="..\packages\Microsoft.SourceLink.GitHub.1.0.0\build\Microsoft.SourceLink.GitHub.props" Condition="Exists('..\packages\Microsoft.SourceLink.GitHub.1.0.0\build\Microsoft.SourceLink.GitHub.props')" />
<Import Project="..\packages\Microsoft.SourceLink.Common.1.0.0\build\Microsoft.SourceLink.Common.props" Condition="Exists('..\packages\Microsoft.SourceLink.Common.1.0.0\build\Microsoft.SourceLink.Common.props')" />
<Import Project="..\packages\Microsoft.Build.Tasks.Git.1.0.0\build\Microsoft.Build.Tasks.Git.props" Condition="Exists('..\packages\Microsoft.Build.Tasks.Git.1.0.0\build\Microsoft.Build.Tasks.Git.props')" />
Expand Down
2 changes: 1 addition & 1 deletion CefSharp.Core.Runtime/CefSharp.Core.Runtime.vcxproj
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build" ToolsVersion="12.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="..\packages\cef.sdk.125.0.21\build\cef.sdk.props" Condition="Exists('..\packages\cef.sdk.125.0.21\build\cef.sdk.props')" />
<Import Project="..\packages\cef.sdk.126.1.14\build\cef.sdk.props" Condition="Exists('..\packages\cef.sdk.126.1.14\build\cef.sdk.props')" />
<Import Project="..\packages\Microsoft.SourceLink.GitHub.1.0.0\build\Microsoft.SourceLink.GitHub.props" Condition="Exists('..\packages\Microsoft.SourceLink.GitHub.1.0.0\build\Microsoft.SourceLink.GitHub.props')" />
<Import Project="..\packages\Microsoft.SourceLink.Common.1.0.0\build\Microsoft.SourceLink.Common.props" Condition="Exists('..\packages\Microsoft.SourceLink.Common.1.0.0\build\Microsoft.SourceLink.Common.props')" />
<Import Project="..\packages\Microsoft.Build.Tasks.Git.1.0.0\build\Microsoft.Build.Tasks.Git.props" Condition="Exists('..\packages\Microsoft.Build.Tasks.Git.1.0.0\build\Microsoft.Build.Tasks.Git.props')" />
Expand Down
11 changes: 9 additions & 2 deletions CefSharp.Core.Runtime/Internals/ClientAdapter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -958,8 +958,13 @@ namespace CefSharp
}
}

bool ClientAdapter::OnFileDialog(CefRefPtr<CefBrowser> browser, FileDialogMode mode, const CefString& title,
const CefString& default_file_path, const std::vector<CefString>& accept_filters,
bool ClientAdapter::OnFileDialog(CefRefPtr<CefBrowser> browser,
FileDialogMode mode,
const CefString& title,
const CefString& default_file_path,
const std::vector<CefString>& accept_filters,
const std::vector<CefString>& accept_extensions,
const std::vector<CefString>& accept_descriptions,
CefRefPtr<CefFileDialogCallback> callback)
{
auto handler = _browserControl->DialogHandler;
Expand All @@ -979,6 +984,8 @@ namespace CefSharp
StringUtils::ToClr(title),
StringUtils::ToClr(default_file_path),
StringUtils::ToClr(accept_filters),
StringUtils::ToClr(accept_extensions),
StringUtils::ToClr(accept_descriptions),
callbackWrapper);
}

Expand Down
9 changes: 7 additions & 2 deletions CefSharp.Core.Runtime/Internals/ClientAdapter.h
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,13 @@ namespace CefSharp
virtual DECL void OnDialogClosed(CefRefPtr<CefBrowser> browser) override;

// CefDialogHandler
virtual DECL bool OnFileDialog(CefRefPtr<CefBrowser> browser, FileDialogMode mode, const CefString& title,
const CefString& default_file_path, const std::vector<CefString>& accept_filters,
virtual DECL bool OnFileDialog(CefRefPtr<CefBrowser> browser,
FileDialogMode mode,
const CefString& title,
const CefString& default_file_path,
const std::vector<CefString>& accept_filters,
const std::vector<CefString>& accept_extensions,
const std::vector<CefString>& accept_descriptions,
CefRefPtr<CefFileDialogCallback> callback) override;

//CefDragHandler
Expand Down
8 changes: 4 additions & 4 deletions CefSharp.Core.Runtime/Resource.rc
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#pragma code_page(65001)

1 VERSIONINFO
FILEVERSION 125,0,210
PRODUCTVERSION 125,0,210
FILEVERSION 126,1,140
PRODUCTVERSION 126,1,140
FILEFLAGSMASK 0x17L
#ifdef _DEBUG
FILEFLAGS 0x1L
Expand All @@ -18,10 +18,10 @@ BEGIN
BLOCK "040904b0"
BEGIN
VALUE "FileDescription", "CefSharp.Core"
VALUE "FileVersion", "125.0.210"
VALUE "FileVersion", "126.1.140"
VALUE "LegalCopyright", "Copyright © 2023 The CefSharp Authors"
VALUE "ProductName", "CefSharp"
VALUE "ProductVersion", "125.0.210"
VALUE "ProductVersion", "126.1.140"
END
END
BLOCK "VarFileInfo"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="cef.sdk" version="125.0.21" targetFramework="native" />
<package id="cef.sdk" version="126.1.14" targetFramework="native" />
<package id="Microsoft.Build.Tasks.Git" version="1.0.0" targetFramework="native" developmentDependency="true" />
<package id="Microsoft.SourceLink.Common" version="1.0.0" targetFramework="native" developmentDependency="true" />
<package id="Microsoft.SourceLink.GitHub" version="1.0.0" targetFramework="native" developmentDependency="true" />
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="cef.sdk" version="125.0.21" targetFramework="netcoreapp3.1" />
<package id="cef.sdk" version="126.1.14" targetFramework="netcoreapp3.1" />
<package id="Microsoft.Build.Tasks.Git" version="1.0.0" targetFramework="native" developmentDependency="true" />
<package id="Microsoft.SourceLink.Common" version="1.0.0" targetFramework="native" developmentDependency="true" />
<package id="Microsoft.SourceLink.GitHub" version="1.0.0" targetFramework="native" developmentDependency="true" />
Expand Down
2 changes: 1 addition & 1 deletion CefSharp.Example/Handlers/TempFileDialogHandler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ namespace CefSharp.Example.Handlers
{
public class TempFileDialogHandler : DialogHandler
{
protected override bool OnFileDialog(IWebBrowser chromiumWebBrowser, IBrowser browser, CefFileDialogMode mode, string title, string defaultFilePath, List<string> acceptFilters, IFileDialogCallback callback)
protected override bool OnFileDialog(IWebBrowser chromiumWebBrowser, IBrowser browser, CefFileDialogMode mode, string title, string defaultFilePath, IReadOnlyCollection<string> acceptFilters, IReadOnlyCollection<string> acceptExtensions, IReadOnlyCollection<string> acceptDescriptions, IFileDialogCallback callback)
{
callback.Continue(new List<string> { Path.GetRandomFileName() });

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
</None>
</ItemGroup>
<ItemGroup>
<PackageReference Include="chromiumembeddedframework.runtime" Version="125.0.21" />
<PackageReference Include="chromiumembeddedframework.runtime" Version="126.1.14" />
</ItemGroup>
<ItemGroup>
<Compile Remove="bin.netcore\**" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
<ProjectReference Include="..\CefSharp.Example\CefSharp.Example.netcore.csproj" />
<ProjectReference Include="..\CefSharp.OffScreen\CefSharp.OffScreen.netcore.csproj" />
<ProjectReference Include="..\CefSharp\CefSharp.netcore.csproj" />
<PackageReference Include="chromiumembeddedframework.runtime" Version="125.0.21" />
<PackageReference Include="chromiumembeddedframework.runtime" Version="126.1.14" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion CefSharp.OffScreen.Example/app.manifest
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
xmlns:asmv3="urn:schemas-microsoft-com:asm.v3"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">

<assemblyIdentity version="125.0.210.0" name="CefSharp.OffScreen.Example.app" />
<assemblyIdentity version="126.1.140.0" name="CefSharp.OffScreen.Example.app" />
<trustInfo xmlns="urn:schemas-microsoft-com:asm.v2">
<security>
<requestedPrivileges xmlns="urn:schemas-microsoft-com:asm.v3">
Expand Down
2 changes: 1 addition & 1 deletion CefSharp.Test/CefSharp.Test.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
<ItemGroup>
<PackageReference Include="Appveyor.TestLogger" Version="2.0.0" />
<PackageReference Include="Bogus" Version="35.4.1" />
<PackageReference Include="chromiumembeddedframework.runtime" Version="125.0.21" />
<PackageReference Include="chromiumembeddedframework.runtime" Version="126.1.14" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.11.0" />

<PackageReference Include="Moq" Version="4.13.0" />
Expand Down
2 changes: 1 addition & 1 deletion CefSharp.Test/CefSharp.Test.netcore.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
<ProjectReference Include="..\CefSharp.Wpf\CefSharp.Wpf.netcore.csproj" />
<ProjectReference Include="..\CefSharp.Example\CefSharp.Example.netcore.csproj" />
<PackageReference Include="Bogus" Version="35.4.1" />
<PackageReference Include="chromiumembeddedframework.runtime" Version="125.0.21" />
<PackageReference Include="chromiumembeddedframework.runtime" Version="126.1.14" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion CefSharp.WinForms.Example/CefSharp.WinForms.Example.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
<ProjectReference Include="..\CefSharp\CefSharp.csproj" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="chromiumembeddedframework.runtime" Version="125.0.21" />
<PackageReference Include="chromiumembeddedframework.runtime" Version="126.1.14" />
</ItemGroup>
<ItemGroup>
<Compile Remove="bin.netcore\**" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
<ProjectReference Include="..\CefSharp.Example\CefSharp.Example.netcore.csproj" />
<ProjectReference Include="..\CefSharp.WinForms\CefSharp.WinForms.netcore.csproj" />
<ProjectReference Include="..\CefSharp\CefSharp.netcore.csproj" />
<PackageReference Include="chromiumembeddedframework.runtime" Version="125.0.21" />
<PackageReference Include="chromiumembeddedframework.runtime" Version="126.1.14" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion CefSharp.WinForms.Example/app.manifest
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
xmlns:asmv3="urn:schemas-microsoft-com:asm.v3"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">

<assemblyIdentity version="125.0.210.0" name="CefSharp.WinForms.Example.app" />
<assemblyIdentity version="126.1.140.0" name="CefSharp.WinForms.Example.app" />

<dependency>
<dependentAssembly>
Expand Down
2 changes: 1 addition & 1 deletion CefSharp.Wpf.Example/CefSharp.Wpf.Example.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<Folder Include="Assets\Images\" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="chromiumembeddedframework.runtime" Version="125.0.21" />
<PackageReference Include="chromiumembeddedframework.runtime" Version="126.1.14" />
<PackageReference Include="MaterialDesignThemes" Version="4.8.0" />
</ItemGroup>
<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion CefSharp.Wpf.Example/CefSharp.Wpf.Example.netcore.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<ProjectReference Include="..\CefSharp.Example\CefSharp.Example.netcore.csproj" />
<ProjectReference Include="..\CefSharp.Wpf\CefSharp.Wpf.netcore.csproj" />
<ProjectReference Include="..\CefSharp\CefSharp.netcore.csproj" />
<PackageReference Include="chromiumembeddedframework.runtime" Version="125.0.21" />
<PackageReference Include="chromiumembeddedframework.runtime" Version="126.1.14" />
<PackageReference Include="System.Runtime.InteropServices.WindowsRuntime" Version="4.3.0" />
<PackageReference Include="MaterialDesignThemes" Version="4.8.0" />
</ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion CefSharp.Wpf.Example/app.manifest
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
xmlns:asmv3="urn:schemas-microsoft-com:asm.v3"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">

<assemblyIdentity version="125.0.210.0" name="CefSharp.Wpf.Example.app" />
<assemblyIdentity version="126.1.140.0" name="CefSharp.Wpf.Example.app" />
<trustInfo xmlns="urn:schemas-microsoft-com:asm.v2">
<security>
<requestedPrivileges xmlns="urn:schemas-microsoft-com:asm.v3">
Expand Down
4 changes: 2 additions & 2 deletions CefSharp.shfbproj
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<DocumentationSource sourceFile="CefSharp.WinForms\CefSharp.WinForms.csproj" />
<DocumentationSource sourceFile="CefSharp.Wpf\CefSharp.Wpf.csproj" />
</DocumentationSources>
<HelpFileVersion>125.0.210</HelpFileVersion>
<HelpFileVersion>126.1.140</HelpFileVersion>
<MaximumGroupParts>2</MaximumGroupParts>
<NamespaceGrouping>False</NamespaceGrouping>
<SyntaxFilters>C#, Managed C++</SyntaxFilters>
Expand Down Expand Up @@ -59,7 +59,7 @@
<Filter entryType="Namespace" fullName="CefSharp.Wpf.Internals" isExposed="False" xmlns="" />
</ApiFilter>
<VisibleItems>InheritedMembers, InheritedFrameworkMembers, Protected, ProtectedInternalAsProtected, EditorBrowsableNever, NonBrowsable</VisibleItems>
<HeaderText>Version 125.0.210</HeaderText>
<HeaderText>Version 126.1.140</HeaderText>
<CopyrightHref>https://raw.githubusercontent.com/cefsharp/CefSharp/master/LICENSE</CopyrightHref>
<NamespaceSummaries>
<NamespaceSummaryItem name="CefSharp" isDocumented="True">Interfaces, enums, structs and classes that make up the core API interface</NamespaceSummaryItem>
Expand Down
16 changes: 13 additions & 3 deletions CefSharp/Handler/DialogHandler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,12 @@ bool IDialogHandler.OnFileDialog(
CefFileDialogMode mode,
string title,
string defaultFilePath,
List<string> acceptFilters,
IReadOnlyCollection<string> acceptFilters,
IReadOnlyCollection<string> acceptExtensions,
IReadOnlyCollection<string> acceptDescriptions,
IFileDialogCallback callback)
{
return OnFileDialog(chromiumWebBrowser, browser, mode, title, defaultFilePath, acceptFilters, callback);
return OnFileDialog(chromiumWebBrowser, browser, mode, title, defaultFilePath, acceptFilters, acceptExtensions, acceptDescriptions, callback);
}

/// <summary>
Expand All @@ -46,6 +48,12 @@ bool IDialogHandler.OnFileDialog(
/// (a) valid lower-cased MIME types (e.g. "text/*" or "image/*"),
/// (b) individual file extensions (e.g. ".txt" or ".png"),
/// (c) combined description and file extension delimited using "|" and ";" (e.g. "Image Types|.png;.gif;.jpg").</param>
/// <param name="acceptExtensions">provides the semicolon-delimited expansion of MIME
/// types to file extensions (if known, or empty string otherwise).</param>
/// <param name="acceptDescriptions">
/// Provides the descriptions for MIME types (if known, or empty string otherwise).
/// For example, the 'image/*' mime type might have extensions ".png;.jpg;.bmp;..." and description 'Image Files'
/// </param>
/// <param name="callback">Callback interface for asynchronous continuation of file dialog requests.</param>
/// <returns>To display a custom dialog return true. To display the default dialog return false.</returns>
protected virtual bool OnFileDialog(
Expand All @@ -54,7 +62,9 @@ protected virtual bool OnFileDialog(
CefFileDialogMode mode,
string title,
string defaultFilePath,
List<string> acceptFilters,
IReadOnlyCollection<string> acceptFilters,
IReadOnlyCollection<string> acceptExtensions,
IReadOnlyCollection<string> acceptDescriptions,
IFileDialogCallback callback)
{
return false;
Expand Down
Loading

0 comments on commit ed6a983

Please sign in to comment.