Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passkey auto-upgrade need to skip user presence & verification check #432

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nov
Copy link

@nov nov commented Sep 17, 2024

new iOS / macOS now support passkey auto upgrade.
it doesn't support neither UV nor UP, and both flags are false by default.

to accept such attestations, those changes are needed.

baala3

This comment was marked as spam.

@nov
Copy link
Author

nov commented Oct 7, 2024

is this repository still active?

Copy link
Contributor

@santiagorodriguez96 santiagorodriguez96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nov! Thank you for taking the time to add this!

I'm wondering if this means we can deprecate the config silent_authentication – which was initially added to pass conformance tests – as it feels to me that it will be easier to understand the purpose of this new user_presence param. That would probably mean that we should support this param for the assertion response tho.

Other than that, I think we should also add some tests as part of this PR.

@nov
Copy link
Author

nov commented Oct 9, 2024

In my app, I want to require UV & UP on normal registration, but want to skip them only on the auto upgrade flow.
So, I'm not sure whether RP-wide config is not needed anymore or not.

Plus, I don't know any authenticators which won't require UV nor UP on authentication.
iOS / iPadOS / macOS's passkey auto upgrade implementation is only the case which omit UV & UP right now.

@nov
Copy link
Author

nov commented Oct 10, 2024

and added specs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants