chore: update to Cedar 3.1.4 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Hakanson <kevhak@amazon.com>
cdisselkoen
approved these changes
May 17, 2024
vscode-cedar-wasm/Cargo.toml
Outdated
Comment on lines
47
to
49
|
|
||
| [package.metadata.wasm-pack.profile.release] | ||
| wasm-opt = false |
There was a problem hiding this comment.
intentionally checked in or just for debugging?
There was a problem hiding this comment.
Good catch. I was getting a (new) local error so I added. Might be result of changes on my system from testing including DWARF for wasm debugging.
[INFO]: Optimizing wasm binaries with `wasm-opt`...
[parse exception: expected more elements in list]
Fatal: error parsing wasm
Error: failed to execute `wasm-opt`: exited with exit status: 1
looks like because of WebAssembly/binaryen#5926
hakanson
force-pushed
the
chore/hakanson/cedar-3.1.4
branch
from
391d31f to
a22ae16
Compare
Signed-off-by: Kevin Hakanson <kevhak@amazon.com>
Signed-off-by: Kevin Hakanson <kevhak@amazon.com>
shaobo-he-aws
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
vscode-cedar.I confirm that this PR (choose one, and delete the other options):
Disclaimer
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.