move protobuf code to cedar-policy #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
cdisselkoen
requested review from
adpaco-aws,
shaobo-he-aws and
john-h-kastner-aws
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
|
I'm confused by the current build failure (which happens while trying to compile code that was generated by |
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
|
Build is now passing. CI just reporting that DRT build fails, I will make a separate PR to deal with that (but not merge this until the DRT PR is ready). This PR is ready for review. |
adpaco-aws
reviewed
Feb 7, 2025
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
…public Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
|
Ready for review -- cedar-policy/cedar-spec#532 will address the downstream CI failure for DRT. |
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
john-h-kastner-aws
approved these changes
Feb 11, 2025
cdisselkoen
added a commit
that referenced
this pull request
Feb 11, 2025
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
4 tasks
cdisselkoen
added a commit
that referenced
this pull request
Feb 11, 2025
cdisselkoen
added a commit
that referenced
this pull request
Feb 11, 2025
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
4 tasks
cdisselkoen
added a commit
that referenced
this pull request
Feb 11, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Moves all protobuf-related code out of
cedar_policy_coreandcedar_policy_validatorand into a new (public) submodule ofcedar_policy. This should resolve the build issues which resulted from packages having to depend on.protofiles in other crates.This necessitated various changes to the internal APIs of
cedar_policy_coreandcedar_policy_validator. If someone feels strongly, I can split out those changes into a separate PR.No changes to the public API, other than that the actual Rust structures compiled from protobuf are now public in
cedar_policy, behind theprotobufsexperimental flag.Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy-core,cedar-validator, etc.)I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):cedar-spec, and how you have tested that your updates are correct.)I confirm that
docs.cedarpolicy.com(choose one, and delete the other options):