inconsistent JSON-based schema validation results for actions

[hakanson]

Before opening, please confirm:

• I have searched for duplicate or closed issues.
• I have read the guide for submitting bug reports.
• I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

Bug Category

Schemas and Validation

Describe the bug

Both the cedar cli evaluate command and cedar_policy_validator::ValidatorSchema have a regression compared to 3.x behavior when validating actions in a JSON-based schema

For the schema below, Cedar 3.x would validate with

undeclared action(s): {"Action::"test2"", "Action::"test1""}

but Cedar 4.x has one of these help messages for the SchemaError:

undeclared action: Action::"test1"

undeclared action: Action::"test2"

Expected behavior

Either return both errors with provide a consistent (deterministic) output

Reproduction steps

1. Save the schema in the code snippet as actions.cedarschema.json
2. Run cedar evaluate -s actions.cedarschema.json --schema-format json -l 'Test::"1"' -a 'Action::"doTests"' -r 'Test::"1"' true

Code Snippet

Cedar schema in JSON format

{
  "": {
    "entityTypes": {
      "Test": {}
    },
    "actions": {
      "doTests": {
        "memberOf": [{ "id": "test1" }, { "type": "Action", "id": "test2" }]
      }
    }
  }
}

Log output

CLI output from 4.3.2 compared with 3.4.1

$ cedar --version
cedar-policy-cli 4.3.2

$ cedar evaluate -s actions.cedarschema.json --schema-format json -l 'Test::"1"' -a 'Action::"doTests"' -r 'Test::"1"' true

  × failed to parse schema from file actions.cedarschema.json
  ╰─▶ undeclared action: Action::"test2"
  help: any actions appearing as parents need to be declared as actions

$ cedar evaluate -s actions.cedarschema.json --schema-format json -l 'Test::"1"' -a 'Action::"doTests"' -r 'Test::"1"' true

  × failed to parse schema from file actions.cedarschema.json
  ╰─▶ undeclared action: Action::"test1"
  help: any actions appearing as parents need to be declared as actions

$ cedar --version
cedar-policy-cli 3.4.1

$ cedar evaluate -s actions.cedarschema.json --schema-format json -l 'Test::"1"' -a 'Action::"doTests"' -r 'Test::"1"' true

  × failed to parse schema from file actions.cedarschema.json
  ╰─▶ undeclared action(s): {"Action::\"test2\"", "Action::\"test1\""}

Additional configuration

No response

Operating System

MacOS

Additional information and screenshots

No response

[B-Lorentz]

Working on this