Skip to content

Commit

Permalink
changes requested by review
Browse files Browse the repository at this point in the history
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
  • Loading branch information
cdisselkoen committed Feb 7, 2025
1 parent 81bc6f2 commit 809d94f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
7 changes: 3 additions & 4 deletions cedar-policy/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,9 @@ Cedar Language Version: TBD

- Assume sufficient stack space when it cannot be determined (#1446, resolving #1443).
Note that on platforms not supported by `stacker` (e.g., Wasm, Android), this means
that large inputs may result in stack overflows and crashing the process. On all
platforms supported by `stacker` (Linux, macOS, Windows, iOS, ...), Cedar will
continue to return the graceful error `RecursionLimit` instead of
crashing.
that large inputs may result in stack overflows and crashing the process.
On all platforms supported by `stacker` (Linux, macOS, ...), Cedar will
continue to return the graceful error `RecursionLimit` instead of crashing.

## [4.3.1] - Coming soon
Cedar Language Version: 4.2
Expand Down
6 changes: 3 additions & 3 deletions cedar-policy/src/api.rs
Original file line number Diff line number Diff line change
Expand Up @@ -873,11 +873,11 @@ impl Authorizer {
/// The authorizer uses the `stacker` crate to manage stack size and tries to use a sane default.
/// If the default is not right for you, you can try wrapping the authorizer or individual calls
/// to `is_authorized` in `stacker::grow`.
/// Note that on platforms not supported by `stacker` (e.g., `wasm32`, Android),
/// Note that on platforms not supported by `stacker` (e.g., Wasm, Android),
/// the authorizer will simply assume that the stack size is sufficient. As a result, large inputs
/// may result in stack overflows and crashing the process.
/// But on all platforms supported by `stacker` (Linux, macOS, Windows, iOS, ...), Cedar will
/// return the graceful error `RecursionLimit` instead of crashing.
/// But on all platforms supported by `stacker` (Linux, macOS, ...), Cedar will return the
/// graceful error `RecursionLimit` instead of crashing.
/// ```
/// # use cedar_policy::{Authorizer, Context, Entities, EntityId, EntityTypeName,
/// # EntityUid, Request,PolicySet};
Expand Down

0 comments on commit 809d94f

Please sign in to comment.