Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3.x] Cherry-pick #532 (the update for cedar#1452) #545

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

cdisselkoen
Copy link
Contributor

Cherry-picks #532, which is the update for cedar-policy/cedar#1452, which was cherry-picked to 4.3.x in cedar-policy/cedar#1478

Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
@cdisselkoen
Copy link
Contributor Author

Fixed a CI issue which I'm confused why #532 didn't have

@cdisselkoen
Copy link
Contributor Author

This CI failure is even weirder, it's literally failing to build cedar-policy-validator on the release/4.3.x branch. Is that build broken?

@cdisselkoen
Copy link
Contributor Author

cdisselkoen commented Feb 19, 2025

It's needing cedar-policy/cedar#1482

@shaobo-he-aws
Copy link
Contributor

I just merged cedar-policy/cedar#1482. Restarting CI.

@cdisselkoen
Copy link
Contributor Author

CI failure to Docker build is because the Dockerfile builds against the main branch of cedar, even here on the release/4.3.x branch. I guess release/4.3.x and main have previously been close enough that this hasn't been a problem. Seems separate from this PR, I propose we merge this PR and deal with the Docker build separately.

@cdisselkoen cdisselkoen merged commit 95d63f7 into release/4.3.x Feb 20, 2025
5 of 6 checks passed
@cdisselkoen cdisselkoen deleted the cdisselkoen/cherrypick branch February 20, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants