update for cedar#1452 #532
Merged
+45
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
cdisselkoen
requested review from
adpaco-aws,
shaobo-he-aws and
john-h-kastner-aws
adpaco-aws
approved these changes
Feb 7, 2025
shaobo-he-aws
approved these changes
Feb 7, 2025
4 tasks
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
john-h-kastner-aws
approved these changes
Feb 11, 2025
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
|
Confirmed that the problem here is cedar-policy/cedar#1452 itself, not the changes in this PR. Still debugging |
|
The current failures should be fixed by cedar-policy/cedar#1463 |
|
oh no, now an |
|
Current failure should be fixed by cedar-policy/cedar#1464 |
john-h-kastner-aws
approved these changes
Feb 12, 2025
cdisselkoen
added a commit
that referenced
this pull request
Feb 18, 2025
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
cedar-policy/cedar#1452
CI will fail until cedar-policy/cedar#1452 is merged.