remove: remove icon props icon-style and fixed-width #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melaniebmn
force-pushed
the
remove/remove-unused-icon-props
branch
from
7c10c1b to
36a962c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This PR is part of the implementation of the new GCDS icon font. With this update, the icon component will no longer support the
fixed-widthandicon-styleprops. As a result, thefixed-widthandicon-styleprops will be removed.Breaking changes
The following icon props will be removed:
Zenhub ticket
The details for this change can be found in this Zenhub ticket.
Note
This PR is currently based on the feat/add-gcds-icon-font branch to facilitate easier review. It will be rebased to main before merging. The PR introducing the new GCDS icon font can be found here.
⛔ ⛔ ⛔ Do not merge this PR until breaking change release messaging is ready to go. ⛔ ⛔ ⛔