-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add gcds icon font #757
base: main
Are you sure you want to change the base?
Conversation
c98f048
to
fec63dc
Compare
db73693
to
704d13e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking really good! Just a couple small things that I noticed.
Are we able to update the size
of the gcds-icon
in the search component to match closer to the font-awesome size? With the new font it's noticeably different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary | Résumé
This PR implements the new GCDS icon font into the icon component, replacing the previously used Font Awesome font. The GCDS icon font provides a more aligned and tailored solution for our project’s iconography needs. All instances where Font Awesome was used have been updated to use the GCDS icon font. This change improves consistency across the project.
Additionally, we have added mobile icon font sizes and line heights to align with our recent typography updates, ensuring a better visual experience across devices.
Changes
Breaking changes
name
prop of the icon to accept only a predefined set of valid inputs.size
prop fromtext
toinherit
.Zenhub ticket
The details for this change can be found in this Zenhub ticket.
Tokens dependency
This PR is dependent on the token update from this token PR.
Note
The
fixed-width
andicon-style
props will no longer be supported for the icon component. They will be removed in a separate PR.⛔ ⛔ ⛔ Do not merge this PR until breaking change release messaging is ready to go. ⛔ ⛔ ⛔