Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gcds icon font #757

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat: add gcds icon font #757

wants to merge 15 commits into from

Conversation

melaniebmn
Copy link
Collaborator

@melaniebmn melaniebmn commented Feb 18, 2025

Summary | Résumé

This PR implements the new GCDS icon font into the icon component, replacing the previously used Font Awesome font. The GCDS icon font provides a more aligned and tailored solution for our project’s iconography needs. All instances where Font Awesome was used have been updated to use the GCDS icon font. This change improves consistency across the project.

Additionally, we have added mobile icon font sizes and line heights to align with our recent typography updates, ensuring a better visual experience across devices.

Changes

  • Replace the Font Awesome icon font with the GCDS font as the icon font family for the icon component.
  • Mobile icon font sizes and line heights to match updated typography guidelines.
  • Update existing components to use the new GCDS icon names.

Breaking changes

  • Update the name prop of the icon to accept only a predefined set of valid inputs.
  • Change the default value of the icon size prop from text to inherit.

Zenhub ticket

The details for this change can be found in this Zenhub ticket.

Tokens dependency

This PR is dependent on the token update from this token PR.

Note

The fixed-width and icon-style props will no longer be supported for the icon component. They will be removed in a separate PR.

⛔ ⛔ ⛔ Do not merge this PR until breaking change release messaging is ready to go. ⛔ ⛔ ⛔

@melaniebmn melaniebmn changed the title Feat/add gcds icon font feat: add gcds icon font Feb 18, 2025
@melaniebmn melaniebmn marked this pull request as ready for review February 19, 2025 16:11
@melaniebmn melaniebmn force-pushed the feat/add-gcds-icon-font branch from c98f048 to fec63dc Compare February 19, 2025 16:13
@melaniebmn melaniebmn force-pushed the feat/add-gcds-icon-font branch from db73693 to 704d13e Compare February 20, 2025 04:10
@melaniebmn melaniebmn requested review from daine and ethanWallace and removed request for daine February 20, 2025 15:53
Copy link
Collaborator

@ethanWallace ethanWallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking really good! Just a couple small things that I noticed.

Are we able to update the size of the gcds-icon in the search component to match closer to the font-awesome size? With the new font it's noticeably different.

ethanWallace
ethanWallace previously approved these changes Mar 3, 2025
Copy link
Collaborator

@ethanWallace ethanWallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@ethanWallace ethanWallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants