clipmenud: avoid spawning multiple daemons #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdown
reviewed
Jun 7, 2024
| @@ -384,6 +385,14 @@ int main(void) { | |||
| int evt_base; | |||
|
|
|||
| cfg = setup("clipmenud"); | |||
|
|
|||
| _drop_(close) int session_fd = | |||
There was a problem hiding this comment.
Done. But does clipmenud do any exec? Also what about content_dir_fd and snip_fd, shouldn't they be O_CLOEXECed too if it's just out of precaution/principle?
There was a problem hiding this comment.
O_CLOEXEC is more important on flock()ed files than regular files because flock() maintains locking semantics across process images, so (for example) clipserve may then end up holding the lock. It would be cleaner elsewhere, too, but less essential.
We do fork()/exec() on run_clipserve().
things can get messy if a running clipmenud is diabled via clipctl and then another clipmenud daemon is started. avoid spawning multiple daemons by using a session lock similar to the old bash script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
things can get messy if a running clipmenud is diabled via clipctl and then another clipmenud daemon is started. avoid spawning multiple daemons by using a session lock similar to the old bash script.