ci: add more linters to golangci-lint #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 3 3
Lines 254 254
=======================================
Hits 251 251
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Please note the tests won't pass, it's normal and expected. The idea is to report the existing issues in the code base. cc @acquisitionist who reported #94 and made me noticed I forgot some linters. Once #94 and #95 will be merged, the PR will be rebased, and the tests will pass. |
Merged
ccoVeille
force-pushed
the
golangci-improvement
branch
from
20b253a to
8453c1c
Compare
- revive.exported - stylecheck Please note, the golangci-lint default exclusions rules I had to disable to make things work as expected.
ccoVeille
force-pushed
the
golangci-improvement
branch
from
8453c1c to
f309faa
Compare
|
now #94 and #95 are merged, everything passes Thanks again @acquisitionist for helping me to spot this, now it would be automatically reported as an error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note, the golangci-lint default exclusions rules I had to disable
to make things work as expected.
For more information, please refer to the golangci-lint documentation about what they call false-positive issues