Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set humidity to 0 if value fails to parse #387

Closed
wants to merge 1 commit into from

Conversation

jadonbaker
Copy link

Addresses issue #366

@cbrandlehner cbrandlehner self-requested a review November 12, 2024 15:07
@jadonbaker jadonbaker closed this Nov 12, 2024
@cbrandlehner
Copy link
Owner

The pull request did not pass the XO checks but I will implement the change in a slightly different form.

Instead of
const currentHumidity = (value => isNaN(value) ? 0 : value)(Number.parseFloat(responseValues.hhum));
I will use
const currentHumidity = (value => Number.isNaN(value) ? 0 : value)(Number.parseFloat(responseValues.hhum));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants