fix: sonarcloud check (opentibiabr#2954)

cblade-gpt · Oct 9, 2024 · 1fcb348 · 1fcb348
1 parent 01e9a81
commit 1fcb348
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 118 deletions.
diff --git a/.github/workflows/analysis-sonarcloud.yml b/.github/workflows/analysis-sonarcloud.yml
diff --git a/sonar-project.properties b/sonar-project.properties
diff --git a/src/lua/callbacks/events_callbacks.hpp b/src/lua/callbacks/events_callbacks.hpp
@@ -89,10 +89,10 @@ class EventsCallbacks {
 	template <typename CallbackFunc, typename... Args>
 	void executeCallback(EventCallback_t eventType, CallbackFunc callbackFunc, Args &&... args) {
 		for (const auto &[name, callback] : getCallbacksByType(eventType)) {
-			auto argsCopy = std::make_tuple(args...);
 			if (callback && callback->isLoadedCallback()) {
+				auto argsCopy = std::make_tuple(args...);
 				std::apply(
-					[&callback, &callbackFunc](auto &&... args) {
+					[callback, &callbackFunc](auto &&... args) {
 						((*callback).*callbackFunc)(std::forward<decltype(args)>(args)...);
 					},
 					argsCopy
@@ -101,6 +101,7 @@ class EventsCallbacks {
 			}
 		}
 	}
+
 	/**
 	 * @brief Checks if all registered callbacks of the specified event type succeed.
 	 * @param eventType The type of event to check.

diff --git a/src/server/network/protocol/protocolgame.cpp b/src/server/network/protocol/protocolgame.cpp
@@ -1883,7 +1883,7 @@ void ProtocolGame::parseQuickLootBlackWhitelist(NetworkMessage &msg) {
 
 void ProtocolGame::parseSay(NetworkMessage &msg) {
 	std::string receiver;
-	uint16_t channelId;
+	uint16_t channelId {};
 
 	SpeakClasses type = static_cast<SpeakClasses>(msg.getByte());
 	switch (type) {

diff --git a/src/server/network/protocol/protocolgame.hpp b/src/server/network/protocol/protocolgame.hpp
@@ -46,10 +46,10 @@ struct TextMessage {
 	MessageClasses type = MESSAGE_STATUS;
 	std::string text;
 	Position position;
-	uint16_t channelId;
+	uint16_t channelId {};
 	struct
 	{
-		int32_t value = 0;
+		int32_t value {};
 		TextColor_t color = TEXTCOLOR_NONE;
 	} primary, secondary;
 };